From: Franck Bui-Huu <franck.bui-huu@innova-card.com>
To: Paul Fulghum <paulkf@microgate.com>
Cc: linux-kernel@vger.kernel.org, linux-os@analogic.com,
pmarques@grupopie.com
Subject: Re: [TTY] 2 points seems strange to me.
Date: Fri, 18 Feb 2005 17:29:07 +0100 [thread overview]
Message-ID: <421617D3.4080207@innova-card.com> (raw)
In-Reply-To: <42160290.3070000@microgate.com>
>> Second point, a lot of serial drivers call in their interrupt handler
>> "tty_flip_buffer_push" function. This function must no be called
>> in interrupt context. Why is it done anyway ?
>
>
> Calling tty_flip_buffer_push() is fine from interrupt
> as long as tty->low_latency is not set. It just queues
> work for later.
>
I was looking at driver for 8250 in 8250.c file and at the end
of "receive_chars" interrupt handler, it calls "tty_flip_buffer_push"
even if "tty->low_latency" is set since no such test is done before
the call...
I was also wondering why not always calling "schedule_delayed_work"
whatever the state of "tty->latency"?
Franck
next prev parent reply other threads:[~2005-02-18 16:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-17 17:51 Problems with dma_mmap_writecombine on mach-pxa Frank Buss
2005-02-17 18:12 ` Russell King
2005-02-17 19:14 ` Frank Buss
2005-02-17 19:58 ` Russell King
2005-02-18 9:30 ` [TTY] 2 points seems strange to me Franck Bui-Huu
2005-02-18 14:58 ` Paul Fulghum
2005-02-18 15:08 ` Paulo Marques
2005-02-18 15:15 ` Paul Fulghum
2005-02-18 15:24 ` Paulo Marques
2005-02-18 15:24 ` linux-os
2005-02-18 15:27 ` Paulo Marques
2005-02-18 16:14 ` Franck Bui-Huu
2005-02-18 15:19 ` linux-os
2005-02-18 16:29 ` Franck Bui-Huu [this message]
2005-02-18 16:41 ` Paul Fulghum
2005-02-18 18:07 ` Problems with dma_mmap_writecombine on mach-pxa Frank Buss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=421617D3.4080207@innova-card.com \
--to=franck.bui-huu@innova-card.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-os@analogic.com \
--cc=paulkf@microgate.com \
--cc=pmarques@grupopie.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.