All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adam Miszczak <adam.miszczak@linux.intel.com>
To: Marcin Bernatowicz <marcin.bernatowicz@linux.intel.com>,
	igt-dev@lists.freedesktop.org
Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>,
	Lukasz Laguna <lukasz.laguna@intel.com>
Subject: Re: [PATCH i-g-t 1/2] benchmarks/gem_wsim: Fail on thread assertions
Date: Thu, 16 Oct 2025 11:21:17 +0200	[thread overview]
Message-ID: <4216c4d2-d862-4f38-b263-b10eb01e61b3@linux.intel.com> (raw)
In-Reply-To: <20250924110607.563913-2-marcin.bernatowicz@linux.intel.com>

On 9/24/2025 1:06 PM, Marcin Bernatowicz wrote:
> Call igt_thread_assert_no_failures() before returning so thread errors
> affect the exit status.
>
> Signed-off-by: Marcin Bernatowicz <marcin.bernatowicz@linux.intel.com>
> Cc: Adam Miszczak <adam.miszczak@linux.intel.com>
> Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> Cc: Lukasz Laguna <lukasz.laguna@intel.com>
> ---
>   benchmarks/gem_wsim.c | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/benchmarks/gem_wsim.c b/benchmarks/gem_wsim.c
> index 7a6b10028..098415b53 100644
> --- a/benchmarks/gem_wsim.c
> +++ b/benchmarks/gem_wsim.c
> @@ -63,6 +63,7 @@
>   #include "i915/gem_mman.h"
>   
>   #include "igt_syncobj.h"
> +#include "igt_thread.h"
>   #include "intel_allocator.h"
>   #include "xe_drm.h"
>   #include "xe/xe_ioctl.h"
> @@ -3362,5 +3363,7 @@ err:
>   	if (is_xe)
>   		xe_device_put(fd);
>   
> +	igt_thread_assert_no_failures();
> +
>   	return exitcode;
>   }

LGTM,
Reviewed-by: Adam Miszczak <adam.miszczak@linux.intel.com>


  parent reply	other threads:[~2025-10-16  9:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-24 11:06 [PATCH i-g-t 0/2] benchmarks/gem_wsim: Thread failures and Xe batch verification Marcin Bernatowicz
2025-09-24 11:06 ` [PATCH i-g-t 1/2] benchmarks/gem_wsim: Fail on thread assertions Marcin Bernatowicz
2025-10-07 14:56   ` Kamil Konieczny
2025-10-16  9:21   ` Adam Miszczak [this message]
2025-09-24 11:06 ` [PATCH i-g-t 2/2] benchmarks/gem_wsim: Verify Xe spinner batch completion Marcin Bernatowicz
2025-10-07 16:22   ` Kamil Konieczny
2025-10-16  9:27   ` Adam Miszczak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4216c4d2-d862-4f38-b263-b10eb01e61b3@linux.intel.com \
    --to=adam.miszczak@linux.intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=kamil.konieczny@linux.intel.com \
    --cc=lukasz.laguna@intel.com \
    --cc=marcin.bernatowicz@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.