From mboxrd@z Thu Jan 1 00:00:00 1970 From: Richard Dawe Subject: Re: [PATCH 2/3] r8169: code clean-up Date: Sun, 20 Feb 2005 17:52:51 +0000 Message-ID: <4218CE73.6010206@phekda.gotadsl.co.uk> References: <200502161823.43562.jdmason@us.ibm.com> <20050217232804.GA4992@electric-eye.fr.zoreil.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Cc: Jon Mason , netdev@oss.sgi.com To: Francois Romieu In-Reply-To: <20050217232804.GA4992@electric-eye.fr.zoreil.com> Sender: netdev-bounce@oss.sgi.com Errors-to: netdev-bounce@oss.sgi.com List-Id: netdev.vger.kernel.org Hello. Francois Romieu wrote: > Jon Mason : [snip] >>adds a link down notification, and cleans up > > > Ok. I'll netif_msg it before someone else complains that the driver > is too verbose. [snip] I started working on adding netif_msg checks to the printks. How far have you got? I don't want to duplicate your work. Incidentally, is there a to-do list somewhere for the r8169 driver? Maybe I can help out with some of the things. Thanks, bye, Rich =] -- Richard Dawe [ http://homepages.nildram.co.uk/~phekda/richdawe/ ] "You can't evaluate a man by logic alone." -- McCoy, "I, Mudd", Star Trek