From: Thomas Monjalon <thomas@monjalon.net>
To: "Guo, Junfeng" <junfeng.guo@intel.com>
Cc: dev@dpdk.org, "Wu, Jingjing" <jingjing.wu@intel.com>
Subject: Re: [PATCH v2] raw/ntb: add PPD status check for SPR
Date: Tue, 05 Jul 2022 21:56:21 +0200 [thread overview]
Message-ID: <4219355.BQQF58Tnoo@thomas> (raw)
In-Reply-To: <DM6PR11MB45784E64BBB2621ACC2D4272E3BD9@DM6PR11MB4578.namprd11.prod.outlook.com>
> > Add PPD (PCIe Port Definition) status check for SPR (Sapphire Rapids).
> >
> > Note that NTB on SPR has the same device id with that on ICX, while
> > the field offsets of PPD Control Register are different. Here, we use
> > the PCI device revision id to distinguish the HW platform (ICX/SPR)
> > and check the Port Config Status and Port Definition accordingly.
> >
> > +---------------------------+--------------------+--------------------+
> > | Fields | Bit Range (on ICX) | Bit Range (on SPR) |
> > +---------------------------+--------------------+--------------------+
> > | Port Configuration Status | 12 | 14 |
> > | Port Definition | 9:8 | 10:8 |
> > +---------------------------+--------------------+--------------------+
> >
> > v2:
> > fix revision id value check logic.
> >
> > Signed-off-by: Junfeng Guo <junfeng.guo@intel.com>
> Acked-by: Jingjing Wu <jingjing.wu@intel.com>
Not sure it is urgent, anyway
Applied, thanks.
prev parent reply other threads:[~2022-07-05 19:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-30 8:39 [PATCH] raw/ntb: add PPD status check for SPR Junfeng Guo
2022-06-30 8:56 ` [PATCH v2] " Junfeng Guo
2022-07-01 9:38 ` Wu, Jingjing
2022-07-05 19:56 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4219355.BQQF58Tnoo@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=junfeng.guo@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.