From: Jeff Garzik <jgarzik@pobox.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Dave Jones <davej@redhat.com>, linux-kernel@vger.kernel.org
Subject: [PATCH #2] Re: slab corruption on 2.6.10-rc4-bk7
Date: Sun, 20 Feb 2005 23:35:17 -0500 [thread overview]
Message-ID: <42196505.5020900@pobox.com> (raw)
In-Reply-To: <42196387.2070505@pobox.com>
[-- Attachment #1: Type: text/plain, Size: 41 bytes --]
Actually, here's a better fix.
Jeff
[-- Attachment #2: libata_probe_ent_free_fix.patch --]
[-- Type: text/x-patch, Size: 621 bytes --]
===== drivers/scsi/libata-core.c 1.116 vs edited =====
--- 1.116/drivers/scsi/libata-core.c 2005-02-01 20:23:51 -05:00
+++ edited/drivers/scsi/libata-core.c 2005-02-20 23:34:32 -05:00
@@ -2800,7 +2800,7 @@
return 1;
/* fall through */
-
+
default:
return 0;
}
@@ -3743,16 +3743,13 @@
if (legacy_mode) {
if (legacy_mode & (1 << 0))
ata_device_add(probe_ent);
- else
- kfree(probe_ent);
if (legacy_mode & (1 << 1))
ata_device_add(probe_ent2);
- else
- kfree(probe_ent2);
- } else {
+ } else
ata_device_add(probe_ent);
- }
+
kfree(probe_ent);
+ kfree(probe_ent2);
return 0;
prev parent reply other threads:[~2005-02-21 4:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-19 22:16 slab corruption on 2.6.10-rc4-bk7 Dave Jones
2005-02-19 22:41 ` Andrew Morton
2005-02-20 2:42 ` Jeff Garzik
2005-02-21 4:28 ` [PATCH] " Jeff Garzik
2005-02-21 4:35 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42196505.5020900@pobox.com \
--to=jgarzik@pobox.com \
--cc=akpm@osdl.org \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.