All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Newport <crn@netunix.com>
To: sparclinux@vger.kernel.org
Subject: Patch: SILO/first-isofs/isofs.c (Fix Sun4c)
Date: Tue, 22 Feb 2005 16:55:10 +0000	[thread overview]
Message-ID: <421B63EE.4040405@netunix.com> (raw)
In-Reply-To: <20050222162933.GA25092@internal>

[-- Attachment #1: Type: text/plain, Size: 403 bytes --]


This small patch fixes silo-1.4.8/first-isofs/isofs.c
Copying an int into a string is not a good idea.

Sun4c now loads second.b and the kernel, but still
barfs loading the initrd.

boot:
Loaded kernel version 2.4.27
Loading initial ramdisk (905216 bytes at 0x0 phys, 0x300000 virt)...
Data Access ExceptionType b (boot), c(continue), or n (new command mode)
 >

Does anyone know what is wrong here ?


[-- Attachment #2: isofs.patch --]
[-- Type: text/plain, Size: 371 bytes --]

--- silo-1.4.8/first-isofs/isofs.c.orig	2005-02-22 13:26:47.000000000 +0000
+++ silo-1.4.8/first-isofs/isofs.c	2005-02-22 16:31:01.000000000 +0000
@@ -68,7 +68,7 @@
 		*s++ = (ap->boot_dev_ctrl & 07) + '0';
 		*s++ = ',';
 		// Hopefully it's never > 10
-		*s++ = ap->boot_dev_unit;
+		*s++ = (ap->boot_dev_unit & 07) + '0';
 		*s++ = ','; 
 		*s++ = '0';
 		*s++ = ')';

  reply	other threads:[~2005-02-22 16:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-02-22 16:29 Patch: SILO/first-isofs/isofs.c (Fix Sun4c) Ben Collins
2005-02-22 16:55 ` Chris Newport [this message]
2005-02-23  1:00 ` Chris Newport
2005-02-23  1:53 ` Ben Collins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=421B63EE.4040405@netunix.com \
    --to=crn@netunix.com \
    --cc=sparclinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.