All of lore.kernel.org
 help / color / mirror / Atom feed
From: "J. David Beutel" <jdb@getsu.com>
To: linux-raid@vger.kernel.org
Subject: RAID1 robust read and read/write correct patch
Date: Wed, 23 Feb 2005 01:01:33 -1000	[thread overview]
Message-ID: <421C628D.8080908@getsu.com> (raw)

I'd like to try this patch 
http://marc.theaimsgroup.com/?l=linux-raid&m=110704868115609&w=2 with 
EVMS BBR.

Has anyone tried it on 2.6.10 (with FC2 1.9 and EVMS patches)?  Has 
anyone tried the rewrite part at all?  I don't know md or the kernel or 
this patch, but the following lines of the patch seem suspicious to me.  
Should it set R1BIO_ReadRewrite instead?  That bit gets tested later, 
whereas it seems like R1BIO_ReadRetry is never tested and 
R1BIO_ReadRewrite is never set.

+#ifdef DO_ADD_READ_WRITE_CORRECT
+	        else    /* tell next time we're here that we're a retry */
+	                set_bit(R1BIO_ReadRetry, &r1_bio->state);
+#endif /* DO_ADD_READ_WRITE_CORRECT */


Cheers,
11011011

             reply	other threads:[~2005-02-23 11:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-02-23 11:01 J. David Beutel [this message]
2005-02-23 11:50 ` RAID1 robust read and read/write correct patch Peter T. Breuer
2005-02-23 20:48   ` J. David Beutel
2005-02-23 21:15     ` Peter T. Breuer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=421C628D.8080908@getsu.com \
    --to=jdb@getsu.com \
    --cc=linux-raid@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.