From: tom watson <lkml@tommywatson.com>
To: linux-kernel@vger.kernel.org
Subject: [PATCH] drivers/net/wan/z85230.c
Date: Wed, 23 Feb 2005 16:08:18 -0500 [thread overview]
Message-ID: <421CF0C2.7010303@tommywatson.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 436 bytes --]
While working on a driver for z85230 based board I noticed what looks
like it could be a problem. If the interrupt handler is handling an
interrupt on port b and an interrupt comes in for port a, it seems to me
that the port b handler would be called instead of the port a handler,
and possibly hang the board until reset.
Attached is a patch to set the irq methods back to port a before
attempting to call them.
Cheers,
Tom.
[-- Attachment #2: z85230.c.patch --]
[-- Type: text/x-patch, Size: 545 bytes --]
--- linux-2.6.10/drivers/net/wan/z85230.c 2004-12-24 16:33:49.000000000 -0500
+++ /home/watsontj/z85230.c 2005-02-23 15:26:32.911085451 -0500
@@ -734,7 +734,7 @@
u8 intr;
static volatile int locker=0;
int work=0;
- struct z8530_irqhandler *irqs=dev->chanA.irqs;
+ struct z8530_irqhandler *irqs;
if(locker)
{
@@ -758,6 +758,8 @@
/* Now walk the chip and see what it is wanting - it may be
an IRQ for someone else remember */
+ irqs=dev->chanA.irqs;
+
if(intr & (CHARxIP|CHATxIP|CHAEXT))
{
if(intr&CHARxIP)
reply other threads:[~2005-02-23 21:09 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=421CF0C2.7010303@tommywatson.com \
--to=lkml@tommywatson.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.