From: Prakash Punnoor <prakashp@arcor.de>
To: Alexey Dobriyan <adobriyan@mail.ru>
Cc: Jeff Garzik <jgarzik@pobox.com>, Andrew Morton <akpm@osdl.org>,
Linus Torvalds <torvalds@osdl.org>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
Mark Lord <mlord@pobox.com>
Subject: Re: [BK PATCHES] 2.6.x libata fixes (mostly)
Date: Wed, 23 Feb 2005 22:28:21 +0100 [thread overview]
Message-ID: <421CF575.20801@arcor.de> (raw)
In-Reply-To: <200502232345.23666.adobriyan@mail.ru>
[-- Attachment #1: Type: text/plain, Size: 487 bytes --]
Alexey Dobriyan schrieb:
> On Wednesday 23 February 2005 21:57, Jeff Garzik wrote:
>>+ addr = sg_dma_address(sg);
>>+ *(u64 *)prd = cpu_to_le64(addr);
>
>
> *(__le64 *) prd
>
>
>>+ prd += sizeof(u64);
>
>
>>+ len = sg_dma_len(sg);
>>+ *(u32 *)prd = cpu_to_le32(len);
>
>
> *(__le32 *) prd
If I am not totally mistaken this is not gcc4 friendly code. (lvalue thing...)
Wouldn't it be better to prevent double patching?
--
Prakash Punnoor
formerly known as Prakash K. Cheemplavam
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2005-02-23 21:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-23 19:57 [BK PATCHES] 2.6.x libata fixes (mostly) Jeff Garzik
2005-02-23 21:45 ` Alexey Dobriyan
2005-02-23 21:24 ` Jeff Garzik
2005-02-23 21:28 ` Prakash Punnoor [this message]
2005-02-23 22:01 ` Roland Dreier
2005-02-23 22:07 ` Prakash Punnoor
2005-02-23 21:57 ` Alexey Dobriyan
2005-02-23 23:26 ` [PATCH 2.6.11+ sata_qstor] libata: sata_qstor cosmetic fixes Mark Lord
2005-02-23 23:39 ` Jeff Garzik
2005-02-24 5:21 ` Jeff Garzik
2005-02-24 15:15 ` Mark Lord
2005-02-25 5:48 ` Jeff Garzik
2005-02-28 16:22 ` [PATCH 2.6.11-rc5+ sata_qstor] sata_qstor: eh_timeout fix Mark Lord
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=421CF575.20801@arcor.de \
--to=prakashp@arcor.de \
--cc=adobriyan@mail.ru \
--cc=akpm@osdl.org \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mlord@pobox.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.