All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Brett Russ <russb@emc.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH libata-2.6] AHCI: print port ID not number
Date: Thu, 24 Feb 2005 14:49:53 -0500	[thread overview]
Message-ID: <421E2FE1.7090703@pobox.com> (raw)
In-Reply-To: <421E2A62.9060303@emc.com>

Brett Russ wrote:
> The attached patch fixes the "ata#: error occurred, port reset" line to 
> display the port id instead of the port number.
> 
> Signed-off-by: Brett Russ <russb@emc.com>
> 
> 
> ------------------------------------------------------------------------
> 
> --- libata-2.6/drivers/scsi/ahci.c      Thu Feb 24 14:18:35 2005
> +++ libata-2.6-ahci-printk/drivers/scsi/ahci.c  Thu Feb 24 14:21:41 2005
> @@ -574,7 +574,7 @@
>         writel(tmp, port_mmio + PORT_CMD);
>         readl(port_mmio + PORT_CMD); /* flush */
> 
> -       printk(KERN_WARNING "ata%u: error occurred, port reset\n", ap->port_no);
> +       printk(KERN_WARNING "ata%u: error occurred, port reset\n", ap->id);

Your patch is corrupted, as <something> converted tabs to spaces.

I highly recommend finding a Unix machine with sendmail, and sending 
patches like this:

The ideal is an inline patch, rather than an attachment anyway.  e.g.

To: ...
From: ...
Subject: ...
<blank line>
Patch description
Patch

cat'd to 'sendmail -t'.  Sendmail (or another MTA which provides a 
/usr/sbin/sendmail wrapper) will automatically fill in other headers 
like Message-ID and Date.

	Jeff



  reply	other threads:[~2005-02-24 19:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-02-24 19:26 [PATCH libata-2.6] AHCI: print port ID not number Brett Russ
2005-02-24 19:49 ` Jeff Garzik [this message]
  -- strict thread matches above, loose matches on Subject: below --
2005-02-24 20:03 Brett Russ
2005-02-24 23:35 ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=421E2FE1.7090703@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=russb@emc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.