From: Jeff Garzik <jgarzik@pobox.com>
To: Arjan van de Ven <arjan@infradead.org>
Cc: Doug Ledford <dledford@redhat.com>,
linux-scsi mailing list <linux-scsi@vger.kernel.org>
Subject: Re: [Patch] QLogic qla2x00 driver fixes
Date: Fri, 25 Feb 2005 03:38:40 -0500 [thread overview]
Message-ID: <421EE410.7020603@pobox.com> (raw)
In-Reply-To: <1109318231.6290.27.camel@laptopd505.fenrus.org>
Arjan van de Ven wrote:
> On Thu, 2005-02-24 at 23:21 -0500, Doug Ledford wrote:
>
>>Don't use cmd->request->nr_hw_segments as it may not be initialized
>>(SG_IO in particular bypasses anything that initializes this and just
>>uses scsi_do_req to insert a scsi_request directly on the head of the
>>queue)
>
>
> should we fix that in the SG_IO layer ?
Possibly/probably.
For SCSI drivers specifically, using nr_hw_segments is pointless unless
cmd->use_sg goes away. At which point tons of SCSI drivers want
changing anyway.
n_sg = dma_map_sg(..., cmd->use_sg, ...)
will always do the right thing, when the cmd contains a scatterlist.
Deviate from the norm and pay the price, really...
Jeff
next prev parent reply other threads:[~2005-02-25 8:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-25 4:21 [Patch] QLogic qla2x00 driver fixes Doug Ledford
2005-02-25 4:28 ` Jeff Garzik
2005-02-25 6:46 ` Andrew Vasquez
2005-02-25 7:43 ` Douglas Gilbert
2005-02-25 7:57 ` Arjan van de Ven
2005-02-25 8:38 ` Jeff Garzik [this message]
2005-02-25 11:57 ` Doug Ledford
2005-02-25 17:02 ` Patrick Mansfield
2005-03-01 6:52 ` Doug Ledford
2005-02-25 17:09 ` Luben Tuikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=421EE410.7020603@pobox.com \
--to=jgarzik@pobox.com \
--cc=arjan@infradead.org \
--cc=dledford@redhat.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.