From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [PATCH] warn when iproute2 or bridge-utils are missing Date: Fri, 25 Feb 2005 15:48:08 -0600 Message-ID: <421F9D18.8000300@us.ibm.com> References: <20050225190856.GA11704@us.ibm.com> <1109362978.12319.88.camel@wopr.tektonic.net> <20050225211946.GB11704@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit In-Reply-To: <20050225211946.GB11704@us.ibm.com> Sender: xen-devel-admin@lists.sourceforge.net Errors-To: xen-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: To: Scott Parish Cc: Matt Ayres , xen-devel@lists.sourceforge.net List-Id: xen-devel@lists.xenproject.org Isn't it more appropriate to have these be install-time checks? It seems wasteful to check for an installed program every time a script is run. I submitted check scripts for iproute2 and iptables a while ago. All you have to do is add a check_iproute2 script to the tools/check directory that basically looks like: #!/bin/sh which ip || (echo "Check for iproute2 failed && exit 1) Regards, Anthony Liguori Scott Parish wrote: >On Fri, Feb 25, 2005 at 03:22:58PM -0500, Matt Ayres wrote: > > > >>On Fri, 2005-02-25 at 19:08 +0000, Scott Parish wrote: >> >> >>>The attached patch checks for "ip" and "brctl" in the path, and warns >>>the user if they are not found. >>> >>> >>> >>Now that the routed setup is included (and IMHO works a whole lot >>better) shouldn't the brctl check be optional somehow? >> >> > >Maybe what i started to do would be better then: make sure that output >from the scripts gets sent to the console in addition to getting buried >in the log file. Then have the scripts check that the programs that they >need are available (before fiddling with the network and putting it in a >half way state). > >sRp > > > ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click