All of lore.kernel.org
 help / color / mirror / Atom feed
From: Darren Hart <dvhltc@us.ibm.com>
To: Chris Wright <chrisw@osdl.org>
Cc: "lkml, " <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] vm: mlock superfluous variable
Date: Fri, 25 Feb 2005 14:21:55 -0800	[thread overview]
Message-ID: <421FA503.6000407@us.ibm.com> (raw)
In-Reply-To: <20050225171122.GE28536@shell0.pdx.osdl.net>

Chris Wright wrote:
> * Darren Hart (dvhltc@us.ibm.com) wrote:
> 
>>The were a couple long standing (since at least 2.4.21) superfluous 
>>variables and two unnecessary assignments in do_mlock().  The intent of 
>>the resulting code is also more obvious.
>>
>>Tested on a 4 way x86 box running a simple mlock test program.  No 
>>problems detected.
> 
> 
> Did you test with multiple page ranges, and locking subsets of vmas?
> Seems that splitting could cause a problem since you now sample vm_end
> before and after fixup, where the vma could be changed in the middle.

Thanks for catching that Chris.  Both the tmp variable and the next 
variable are indeed needed since mlock_fixup could modify both.  Please 
disregard this patch.

--Darren

      parent reply	other threads:[~2005-02-25 22:19 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-02-25  0:43 [PATCH] vm: mlock superfluous variable Darren Hart
2005-02-25 17:11 ` Chris Wright
2005-02-25 22:05   ` [PATCH] allow vma merging with mlock et. al Chris Wright
2005-02-25 22:26     ` Darren Hart
2005-02-25 23:38       ` Chris Wright
2005-02-26  0:56         ` Andrea Arcangeli
2005-02-26  1:13           ` Chris Wright
2005-02-26 17:20     ` Hugh Dickins
2005-02-28 20:33       ` Chris Wright
2005-02-28 20:53         ` Hugh Dickins
2005-02-25 22:21   ` Darren Hart [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=421FA503.6000407@us.ibm.com \
    --to=dvhltc@us.ibm.com \
    --cc=chrisw@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.