From: Adriana Kobylak <anoo@linux.ibm.com>
To: Patrick Williams <patrick@stwcx.xyz>
Cc: OpenBMC List <openbmc@lists.ozlabs.org>,
openbmc <openbmc-bounces+anoo=linux.ibm.com@lists.ozlabs.org>
Subject: Re: sdbusplus - const/readonly flags
Date: Tue, 25 Aug 2020 15:52:42 -0500 [thread overview]
Message-ID: <421fddd2a3f5b352f0cd5b260216bc8b@linux.vnet.ibm.com> (raw)
In-Reply-To: <20200825150028.GK3532@heinlein>
On 2020-08-25 10:00, Patrick Williams wrote:
> * I expect some of the 'const' flags in phosphor-dbus-interfaces are
> wrong and should be changed to 'readonly'. I have collected a
> list
> of them in a gist[4]. If you really intend to mean "this property
> will never change during the life of an object" continue to use
> 'const', but if you mean "this property shall not be changed by
> clients", use 'readonly' (and probably also add 'emits_change').
There are also some properties in phosphor-dbus-interfaces with
descriptions that say "read-only property", and the implementation is
enforcing it. It may good for the owners to revisit those as well and
see if a 'read-only' flag is applicable.
> 1.
> https://manpages.debian.org/experimental/libsystemd-dev/SD_BUS_WRITABLE_PROPERTY.3.en.html#Flags
> 2. https://github.com/openbmc/sdbusplus/issues/48
> 3.
> https://github.com/openbmc/sdbusplus/commit/e1c73d3bf8f6cabc1c58f67a233dba55b6f76d74
> 4.
> https://gist.github.com/williamspatrick/fa975c33f00640ca54a7aa246bbbfeb9
next prev parent reply other threads:[~2020-08-25 20:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-25 15:00 sdbusplus - const/readonly flags Patrick Williams
2020-08-25 17:50 ` Matthew Barth
2020-08-25 18:08 ` Patrick Williams
2020-08-25 20:52 ` Adriana Kobylak [this message]
2020-08-26 15:10 ` Patrick Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=421fddd2a3f5b352f0cd5b260216bc8b@linux.vnet.ibm.com \
--to=anoo@linux.ibm.com \
--cc=openbmc-bounces+anoo=linux.ibm.com@lists.ozlabs.org \
--cc=openbmc@lists.ozlabs.org \
--cc=patrick@stwcx.xyz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.