All of lore.kernel.org
 help / color / mirror / Atom feed
From: walter harms <wharms@bfs.de>
To: kernel-janitors@vger.kernel.org
Subject: [KJ] question ACPI & CMPXCHG
Date: Sun, 27 Feb 2005 16:17:36 +0000	[thread overview]
Message-ID: <4221F2A0.5050105@bfs.de> (raw)
In-Reply-To: <200502271349.20737.vicente.feito@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 824 bytes --]

hi list,
when i was looking into arch/i386/kernel/acpi/boot.c

i found:

#ifndef __HAVE_ARCH_CMPXCHG
#warning ACPI uses CMPXCHG, i486 and later hardware
#endif


perhaps its nitpicking but ...
I think the setup should disable ACPI if CMPXCHG does not exist.
second best generate at least an error ! compile time these day is short 
and you have a good change to miss warnings.

re,
	walter


(since i have no idea about the setup, no patch)

re,
	walter


quick fix (better example) , hopyfully someone can find some better text


--- boot.c.org  2005-02-27 17:10:24.000000000 +0100
+++ boot.c      2005-02-27 17:11:58.000000000 +0100
@@ -82,7 +82,7 @@
  #endif

  #ifndef __HAVE_ARCH_CMPXCHG
-#warning ACPI uses CMPXCHG, i486 and later hardware
+#error  ACPI requires CMPXCHG
  #endif

  #define MAX_MADT_ENTRIES       256

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

  parent reply	other threads:[~2005-02-27 16:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-02-27 13:49 [KJ] question ACPI & CMPXCHG Vicente Feito
2005-02-27 14:50 ` Vicente Feito
2005-02-27 16:17 ` walter harms [this message]
2005-02-27 16:37 ` Adrian Bunk
2005-02-27 17:01 ` Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4221F2A0.5050105@bfs.de \
    --to=wharms@bfs.de \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.