From: Patrick McHardy <kaber@trash.net>
To: johnpol@2ka.mipt.ru
Cc: Harald Welte <laforge@netfilter.org>,
netfilter-devel@lists.netfilter.org
Subject: Re: [1/1] ipt_osf: fix ipt_osf compilation on some distros.
Date: Sun, 27 Feb 2005 17:32:09 +0100 [thread overview]
Message-ID: <4221F609.3060305@trash.net> (raw)
In-Reply-To: <1109308057.6728.54.camel@uganda>
Evgeniy Polyakov wrote:
> Some distros have magical header mess, which leads to undefined struct
> tcphdr,
> when net/tcp.h is not included directly.
> Following patch workarounds it.
You should include linux/tcp.h for struct tcphdr. You probably also
don't need the other net/ includes, for struct iphdr use linux/ip.h,
sock.h shouldn't be needed at all.
> Signed-off-by: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
>
> --- orig/osf/linux-2.6/net/ipv4/netfilter/ipt_osf.c~ 2005-02-07
> 18:55:56.000000000 +0300
> +++orig/osf/linux-2.6/net/ipv4/netfilter/ipt_osf.c 2005-02-24
> 12:49:22.329311368 +0300
> @@ -47,6 +47,7 @@
>
> #include <net/sock.h>
> #include <net/ip.h>
> +#include <net/tcp.h>
>
> #include <linux/netfilter_ipv4/ip_tables.h>
>
>
> P.S. Should I resend lost patch with Subject line
> "[1/1] libipt_osf: fix iptables-1.3.0rc1 compilation.", which moves
> kernel headers in ipt_osf.h into appropriate ifdef/endif?
Yes, please.
Regards
Patrick
next prev parent reply other threads:[~2005-02-27 16:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-25 5:07 [1/1] ipt_osf: fix ipt_osf compilation on some distros Evgeniy Polyakov
2005-02-27 16:32 ` Patrick McHardy [this message]
2005-02-27 17:10 ` Evgeniy Polyakov
2005-02-27 17:03 ` Patrick McHardy
2005-02-27 17:39 ` Evgeniy Polyakov
2005-03-01 20:32 ` Patrick McHardy
2005-02-27 17:11 ` [1/2] ipt_osf: move kernel headers into appropriate ifdef/endif area Evgeniy Polyakov
2005-02-27 17:13 ` [2/2] ipt_osf: includes cleanup Evgeniy Polyakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4221F609.3060305@trash.net \
--to=kaber@trash.net \
--cc=johnpol@2ka.mipt.ru \
--cc=laforge@netfilter.org \
--cc=netfilter-devel@lists.netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.