All of lore.kernel.org
 help / color / mirror / Atom feed
From: Valdis.Kletnieks@vt.edu
To: Florian Mickler <florian@mickler.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	"Rafael J. Wysocki" <rjw@sisk.pl>,
	mark gross <markgross@thegnar.org>,
	e1000-devel@lists.sourceforge.net, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	James Bottomley <James.Bottomley@HansenPartnership.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] Re: mmotm 2010-07-19 - e1000e vs. pm_qos_update_request issues
Date: Thu, 22 Jul 2010 00:05:03 -0400	[thread overview]
Message-ID: <4222.1279771503@localhost> (raw)
In-Reply-To: Your message of "Wed, 21 Jul 2010 09:12:00 +0200." <20100721091200.40c43158@schatten.dmk.lab>

[-- Attachment #1: Type: text/plain, Size: 1072 bytes --]

On Wed, 21 Jul 2010 09:12:00 +0200, Florian Mickler said:

> Attached patch moves the registering from e1000_up to e1000_open and
> the unregistering from e1000_down to e1000_close. 
> It is only compile-tested as I don't have the hardware.

My laptop has the hardware, so I tested it - system does indeed boot
without whinging about this issue.  Feel free to stick in a:

Tested-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>

Thanks for the fast fix. :)

> From 693c71b911ff0845c872261d5704a1d40960722d Mon Sep 17 00:00:00 2001
> From: Florian Mickler <florian@mickler.org>
> Date: Wed, 21 Jul 2010 08:44:21 +0200
> Subject: [PATCH] e1000e: register pm_qos request on hardware activation
> 
> The pm_qos_add_request call has to register the pm_qos request with the pm_qos
> susbsystem before first use of the pm_qos request via
> pm_qos_update_request.
> 
> As pm_qos changed to use plists there is no benefit in registering and
> unregistering the pm_qos request on ifup/ifdown and thus we move the
> registering into e1000_open and the unregistering in e1000_close.



[-- Attachment #2: Type: application/pgp-signature, Size: 227 bytes --]

  parent reply	other threads:[~2010-07-22  4:05 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-19 23:38 mmotm 2010-07-19-16-37 uploaded akpm
2010-07-20 20:35 ` mmotm 2010-07-19 - e1000e vs. pm_qos_update_request issues Valdis.Kletnieks
2010-07-20 21:07   ` Andrew Morton
2010-07-20 21:07     ` Andrew Morton
2010-07-21  7:12     ` [PATCH] " Florian Mickler
2010-07-21 22:12       ` mark gross
2010-07-22  4:05       ` Valdis.Kletnieks [this message]
2010-07-22 21:58         ` Rafael J. Wysocki
2010-07-22 22:37       ` Jeff Kirsher
2010-07-22 22:37         ` Jeff Kirsher
2010-07-21 22:09     ` mark gross
2010-07-21 22:09       ` mark gross
2010-07-20 20:41 ` mmotm 2010-07-19-16-37 uploaded Valdis.Kletnieks
2010-07-20 20:38   ` Jarod Wilson
     [not found]   ` <201007201350.28961.dmitry.torokhov@gmail.com>
2010-07-20 21:11     ` Valdis.Kletnieks
2010-07-20 21:41       ` Jarod Wilson
2010-07-25 18:00         ` Mauro Carvalho Chehab
2010-07-21 12:54 ` mmotm 2010-07-19 - more pm_qos woes - audio this time Valdis.Kletnieks
2010-07-21 12:54   ` Valdis.Kletnieks
2010-07-21 12:59   ` Mark Brown
2010-07-21 12:59     ` [alsa-devel] " Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4222.1279771503@localhost \
    --to=valdis.kletnieks@vt.edu \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=akpm@linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=e1000-devel@lists.sourceforge.net \
    --cc=florian@mickler.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=markgross@thegnar.org \
    --cc=netdev@vger.kernel.org \
    --cc=rjw@sisk.pl \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.