From: Jeff Garzik <jgarzik@pobox.com>
To: Richard Dawe <rich@phekda.gotadsl.co.uk>
Cc: Francois Romieu <romieu@fr.zoreil.com>,
Jon Mason <jdmason@us.ibm.com>,
netdev@oss.sgi.com
Subject: Re: [PATCH]: r8169: Expose hardware stats via ethtool
Date: Sun, 27 Feb 2005 17:59:45 -0500 [thread overview]
Message-ID: <422250E1.6000307@pobox.com> (raw)
In-Reply-To: <42224F76.9000602@phekda.gotadsl.co.uk>
Richard Dawe wrote:
>> BUG() is a bit exagerated imho.
>
>
> It seems like a pretty good way of avoiding a buffer overrun to me.
> E.g.: you copy an extra statistic in rtl8169_get_ethtool_stats(), but
> forget to update the stats length. Is it not better to crash early, than
> encounter random behaviour later?
Yeah, that's why the BUG() is present in 8139cp: force an oops rather
than continue corrupting memory, if the programmer made an error.
Jeff
next prev parent reply other threads:[~2005-02-27 22:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-26 14:53 [PATCH]: r8169: Expose hardware stats via ethtool Richard Dawe
2005-02-26 15:57 ` Jeff Garzik
2005-02-27 22:46 ` Richard Dawe
2005-02-26 17:32 ` Jon Mason
2005-02-26 18:02 ` Jeff Garzik
2005-02-26 18:03 ` Jeff Garzik
2005-02-26 18:12 ` Francois Romieu
2005-02-27 22:53 ` Richard Dawe
2005-02-27 22:59 ` Jeff Garzik [this message]
2005-02-28 2:31 ` Jon Mason
2005-02-28 2:58 ` Jeff Garzik
2005-02-28 4:16 ` Ben Greear
2005-03-05 13:53 ` Richard Dawe
2005-02-26 18:36 ` Jon Mason
2005-02-26 18:26 ` Francois Romieu
2005-02-27 22:44 ` Richard Dawe
2005-02-27 19:28 ` Jon Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=422250E1.6000307@pobox.com \
--to=jgarzik@pobox.com \
--cc=jdmason@us.ibm.com \
--cc=netdev@oss.sgi.com \
--cc=rich@phekda.gotadsl.co.uk \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.