All of lore.kernel.org
 help / color / mirror / Atom feed
From: Victoria Dye <vdye@github.com>
To: Shuqi Liang <cheskaqiqi@gmail.com>, git@vger.kernel.org
Cc: gitster@pobox.com
Subject: Re: [PATCH v2] worktree: integrate with sparse-index
Date: Wed, 7 Jun 2023 10:21:22 -0700	[thread overview]
Message-ID: <4225a82c-83cc-d81a-628d-a9a01d02acf2@github.com> (raw)
In-Reply-To: <20230606172633.669916-1-cheskaqiqi@gmail.com>

Shuqi Liang wrote:
> Range-diff against v1:
> 
> * Fix did't to didn't.
> 
> * Add ensure_not_expanded for "git worktree add".
> 
> * Add a section that compares each test repo's default worktree to
> a new worktree.

Thanks for these updates! Everything looks good to me (especially the checks
you've added to the 'worktree' test).


      reply	other threads:[~2023-06-07 17:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-05 16:16 [PATCH v1] worktree: integrate with sparse-index Shuqi Liang
2023-06-05 19:16 ` Victoria Dye
2023-06-05 20:16   ` Shuqi Liang
2023-06-06  4:22     ` Victoria Dye
2023-06-06 17:26 ` [PATCH v2] " Shuqi Liang
2023-06-07 17:21   ` Victoria Dye [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4225a82c-83cc-d81a-628d-a9a01d02acf2@github.com \
    --to=vdye@github.com \
    --cc=cheskaqiqi@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.