Re: [PATCH] TCP window tracking patch with nfsim testsuite

[Patrick McHardy <kaber@trash.net>]

Jozsef Kadlecsik wrote:
> Hi,
> 
> The first attached patch addresses several problems in the current TCP
> connection tracking in the 2.6 tree. Some of the problems was reported,
> others was discovered by nfsim tests:
> 
> - tcp_sack function was not safe against nonlinear skbs
> - practically arbitrary RST segments (addresses, ports assumed to be
>   known) could cause connection teardown in conntrack (thanks to Tim
>   Burress for the bugreport and patch)
> - article on which the code was based falsely assumed that packets
>   must fit completely into the window: packets must at least overlap
>   (thanks to Phil Oester for the bugreport and patch)
> - state table slightly changed to handle ACK packets sent by server to
>   late resent SYNs
> - tracking reopening connections reworked
> - cosmetic change: when window tracking is ignored by setting
>   ip_conntrack_tcp_be_liberal to nonzero, it's ignored completely from
>   now on
> 
> I think, after review, the patch should be sent for kernel inclusion.

Unfortunately there are too many changes for me to give it some
good review, but I've been running it for some time now without
problems. I'm going to push it to Dave with my next batch of
patches.

Regards
Patrick