From: "Randy.Dunlap" <rddunlap@osdl.org>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: Vojtech Pavlik <vojtech@suse.cz>,
B.Zolnierkiewicz@elka.pw.edu.pl, akpm <akpm@osdl.org>,
linux-ide@vger.kernel.org
Subject: Re: [PATCH] ide/amd74xx: fix section references
Date: Fri, 04 Mar 2005 07:33:20 -0800 [thread overview]
Message-ID: <42287FC0.6060204@osdl.org> (raw)
In-Reply-To: <58cb370e05030402122a9290b6@mail.gmail.com>
Bartlomiej Zolnierkiewicz wrote:
> On Fri, 4 Mar 2005 09:03:07 +0100, Vojtech Pavlik <vojtech@suse.cz> wrote:
>
>>On Thu, Mar 03, 2005 at 07:48:21PM -0800, Randy.Dunlap wrote:
>>
>>>ide/pci/amd74xx: data structs point to __init text which should be
>>> __devinit;
>>>unless (a) these are going away real soon,
>>>or (b) this just can't happen, isn't a real problem,
>>>or (c) other ?
>>
>>This is a problem in most of the IDE PCI drivers. It is a problem if IDE
>>hotplug is to be expected, and shouldn't be causing any immediate harm
>>if IDE controllers can't be hotplugged. AMD74xx certainly can't.
Yes, I have a list of other offenders, I just wanted to get
comments first.
>>However, I believe it's correct to fix that.
>
>
> Some time ago hch made a patch fixing all IDE PCI drivers.
> It was queued to be merged after hotplug support is added
> but may be merged earlier if needed (to kill sparse warnings?).
So I don't need to fix the remaining offenders, right?
--
~Randy
next prev parent reply other threads:[~2005-03-04 15:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-04 3:48 [PATCH] ide/amd74xx: fix section references Randy.Dunlap
2005-03-04 8:03 ` Vojtech Pavlik
2005-03-04 10:12 ` Bartlomiej Zolnierkiewicz
2005-03-04 15:33 ` Randy.Dunlap [this message]
2005-03-04 15:40 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42287FC0.6060204@osdl.org \
--to=rddunlap@osdl.org \
--cc=B.Zolnierkiewicz@elka.pw.edu.pl \
--cc=akpm@osdl.org \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=vojtech@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.