All of lore.kernel.org
 help / color / mirror / Atom feed
From: Corey Minyard <minyard@acm.org>
To: Adrian Bunk <bunk@stusta.de>
Cc: Bene Martin <martin.bene@icomedias.com>,
	minyard@mvista.com, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] readd ipmi_request
Date: Sun, 06 Mar 2005 16:43:04 -0600	[thread overview]
Message-ID: <422B8778.6040401@acm.org> (raw)
In-Reply-To: <20050305180346.GF6373@stusta.de>

Adrian Bunk wrote:

>On Sat, Mar 05, 2005 at 10:41:31AM +0100, Bene Martin wrote:
>
>  
>
>>Hi Adrian,
>>
>>bmcsensors package (reading hardware sensors provided by intel boards
>>via ipmi) used to work fine with 2.6.10; no longer works with 2.6.11
>>because of removal of the ipmi_request function (+ exported symbol).
>>
>>correct fix would be to use ipmi_request_settime with retries=-1 and
>>retry_time_ms=0?
>>    
>>
>
>I didn't know about this, the patch below readds ipmi_request.
>  
>
IMHO, it's probably better to modify your patch to use 
ipmi_request_settime.  That function is there is all recent kernels.  
Unfortunately, I can't magically re-add the ipmi_request function to 
2.6.11, and it would be less confusing to have a new patch for 
bmcsensors that worked with stock 2.6.11.

Again, sorry about this.

-Corey

      reply	other threads:[~2005-03-06 22:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-05  9:41 ipmi in kernel 2.6.11 Bene Martin
2005-03-05 15:41 ` Corey Minyard
2005-03-05 18:03 ` [2.6 patch] readd ipmi_request Adrian Bunk
2005-03-06 22:43   ` Corey Minyard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=422B8778.6040401@acm.org \
    --to=minyard@acm.org \
    --cc=bunk@stusta.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.bene@icomedias.com \
    --cc=minyard@mvista.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.