From: Patrick McHardy <kaber@trash.net>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: davem@davemloft.net, netdev@oss.sgi.com
Subject: Re: [PATCH 3/3 XFRM]: Fix invalid key for lookup of cached bundles
Date: Mon, 07 Mar 2005 02:41:30 +0100 [thread overview]
Message-ID: <422BB14A.5030302@trash.net> (raw)
In-Reply-To: <20050307012458.GA4335@gondor.apana.org.au>
Herbert Xu wrote:
> On Sun, Mar 06, 2005 at 01:34:24PM +0100, Patrick McHardy wrote:
>
>>How about this one ? It keeps the DST_XFRM_TUNNEL flag and sets it on
>>the first xfrm_dst in a bundle. I know it doesn't really belong there,
>
>
> Actually, why do we need to treat tunnel mode differently here?
> In other words, why not just do the mark/tos checks unconditionally.
>
> Forwarded packets don't get a proper tos/mark setting for IPsec
> but that's a bug in itself.
Mainly to avoid excessive long lists of cached bundles in tunnel
mode. The use of a single list for the cache is questionable, but
the patch was supposed to fix a different issue. Restricting use
of tos/mark to transport mode avoids having exploding lists that
are easily remotely triggerable.
Regards
Patrick
next prev parent reply other threads:[~2005-03-07 1:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-05 13:59 [PATCH 3/3 XFRM]: Fix invalid key for lookup of cached bundles Patrick McHardy
2005-03-06 10:29 ` Herbert Xu
2005-03-06 10:54 ` Patrick McHardy
2005-03-06 12:34 ` Patrick McHardy
2005-03-06 17:55 ` Patrick McHardy
2005-03-07 1:24 ` Herbert Xu
2005-03-07 1:41 ` Patrick McHardy [this message]
2005-03-07 1:43 ` Herbert Xu
2005-03-07 1:55 ` Patrick McHardy
2005-03-07 1:59 ` Herbert Xu
2005-03-07 2:30 ` Patrick McHardy
2005-03-07 2:57 ` Herbert Xu
2005-03-07 3:11 ` Patrick McHardy
2005-03-15 5:51 ` David S. Miller
2005-03-15 6:01 ` Herbert Xu
2005-03-15 6:14 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=422BB14A.5030302@trash.net \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.