From: Patrick McHardy <kaber@trash.net>
To: Pablo Neira <pablo@eurodev.net>
Cc: Netfilter Development Mailinglist <netfilter-devel@lists.netfilter.org>
Subject: Re: [PATCH 1/2] Move tcp_adjust to generic layer
Date: Wed, 09 Mar 2005 01:38:41 +0100 [thread overview]
Message-ID: <422E4591.7080805@trash.net> (raw)
In-Reply-To: <422B8D98.3000501@trash.net>
Patrick McHardy wrote:
> Pablo Neira wrote:
>
>> Hi Patrick,
>>
>> This patch moves tcp_adjust to a generic layer. I sent something
>> similar some time ago but it seems that it got lost.
>
>
> IIRC the argument against this patch was that it is entirely specific
> to TCP. Can't we simply move it all to TCP's manip_pkt() function ?
Thinking about it, this would also allow to solve a differnt issue
nicely. TCP packets contained in ICMP errors don't have their
sequence numbers adjusted backwards, theoretically this can cause
them to be discarded by the receipient. It would require an additional
argument to manip_pkt, for ICMP packets we can't simply apply the
adjustment of the reverse direction, but need to apply it inversely.
Perhaps it can also be deduced from iphdroff and skb->nh.iph.
What do you think ?
Regards
Patrick
prev parent reply other threads:[~2005-03-09 0:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-06 22:40 [PATCH 1/2] Move tcp_adjust to generic layer Pablo Neira
2005-03-06 23:09 ` Patrick McHardy
2005-03-09 0:38 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=422E4591.7080805@trash.net \
--to=kaber@trash.net \
--cc=netfilter-devel@lists.netfilter.org \
--cc=pablo@eurodev.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.