From: Jeff Garzik <jgarzik@pobox.com>
To: "David S. Miller" <davem@davemloft.net>, netdev@oss.sgi.com
Cc: Stephen Hemminger <shemminger@osdl.org>
Subject: [PATCH] kill ->accept_fastpath hook
Date: Wed, 09 Mar 2005 13:47:52 -0500 [thread overview]
Message-ID: <422F44D8.3010009@pobox.com> (raw)
In-Reply-To: <20050309092628.3c9014db@dxpl.pdx.osdl.net>
[-- Attachment #1: Type: text/plain, Size: 345 bytes --]
Stephen Hemminger wrote:
> Trivial reordering of netdevice structure to save four bytes.
>
> Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
If we are twiddling struct net_device, might as well kill this hook.
Never called AFAICS, and only assigned -- to a no-op stub -- in one driver.
Signed-off-by: Jeff Garzik <jgarzik@pobox.com>
[-- Attachment #2: patch --]
[-- Type: text/plain, Size: 1108 bytes --]
===== include/linux/netdevice.h 1.99 vs edited =====
--- 1.99/include/linux/netdevice.h 2005-02-11 00:54:25 -05:00
+++ edited/include/linux/netdevice.h 2005-03-09 13:26:25 -05:00
@@ -469,7 +469,6 @@
int (*hard_header_parse)(struct sk_buff *skb,
unsigned char *haddr);
int (*neigh_setup)(struct net_device *dev, struct neigh_parms *);
- int (*accept_fastpath)(struct net_device *, struct dst_entry*);
#ifdef CONFIG_NETPOLL
int netpoll_rx;
#endif
===== net/bridge/br_device.c 1.17 vs edited =====
--- 1.17/net/bridge/br_device.c 2004-07-29 17:40:51 -04:00
+++ edited/net/bridge/br_device.c 2005-03-09 13:26:08 -05:00
@@ -83,11 +83,6 @@
return 0;
}
-static int br_dev_accept_fastpath(struct net_device *dev, struct dst_entry *dst)
-{
- return -1;
-}
-
void br_dev_setup(struct net_device *dev)
{
memset(dev->dev_addr, 0, ETH_ALEN);
@@ -103,7 +98,6 @@
dev->destructor = free_netdev;
SET_MODULE_OWNER(dev);
dev->stop = br_dev_stop;
- dev->accept_fastpath = br_dev_accept_fastpath;
dev->tx_queue_len = 0;
dev->set_mac_address = NULL;
dev->priv_flags = IFF_EBRIDGE;
next prev parent reply other threads:[~2005-03-09 18:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-09 17:26 [PATCH] rearrange netdevice structure to save space Stephen Hemminger
2005-03-09 18:47 ` Jeff Garzik [this message]
2005-03-09 18:55 ` [PATCH] kill ->accept_fastpath hook Stephen Hemminger
2005-03-11 2:19 ` David S. Miller
2005-03-11 2:41 ` [PATCH] rearrange netdevice structure to save space David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=422F44D8.3010009@pobox.com \
--to=jgarzik@pobox.com \
--cc=davem@davemloft.net \
--cc=netdev@oss.sgi.com \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.