From: Steven Pratt <slpratt@austin.ibm.com>
To: Ram <linuxram@us.ibm.com>
Cc: Oleg Nesterov <oleg@tv-sign.ru>,
linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH 2/2] readahead: improve sequential read detection
Date: Wed, 09 Mar 2005 18:03:10 -0600 [thread overview]
Message-ID: <422F8EBE.5080803@austin.ibm.com> (raw)
In-Reply-To: <1110412324.4816.89.camel@localhost>
Ram wrote:
>On Wed, 2005-03-02 at 11:08, Oleg Nesterov wrote:
>
>
>..snip...
>
>
>
>>@@ -527,7 +527,7 @@ page_cache_readahead(struct address_spac
>> }
>>
>> out:
>>- return newsize;
>>+ return ra->prev_page + 1;
>>
>>
>
>This change introduces one key behavioural change in
>page_cache_readahead(). Instead of returning the number-of-pages
>successfully read, it now returns the next-page-index which is yet to be
>read. Was this essential?
>
>
>
and unless filmap.c was changed accordingly this is broken.. need. to
look at this more.
Steve
>At least, a comment towards this effect at the top of the function is
>worth adding.
>
>RP
>
>
next prev parent reply other threads:[~2005-03-10 0:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-02 19:08 [PATCH 2/2] readahead: improve sequential read detection Oleg Nesterov
2005-03-03 2:01 ` Andrew Morton
2005-03-09 23:52 ` Ram
2005-03-10 0:03 ` Steven Pratt [this message]
2005-03-10 0:06 ` Ram
2005-03-10 17:14 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=422F8EBE.5080803@austin.ibm.com \
--to=slpratt@austin.ibm.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxram@us.ibm.com \
--cc=oleg@tv-sign.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.