From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 14912C71135 for ; Sat, 14 Jun 2025 00:44:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=60VJTWMro2LidkONNc4Wn5msfgIDLUS0+quQTAQe3Pw=; b=ul/fUZJOumaERx xAuyFbYwOD3DOVOqPFWADO4BkqZAIM+nN3cdhnkMiBdRIvHns0Luk/upYmko7SsBE8iBk7pOBLCBE DwsZsTiGDwgERGpU3ZQU2CoeRE0EKgWRjIBWesuDs1V2mMesnNQA3tgEyw669Wu/dIb8biSIVxkqd gDASNpf+7rJN9NZ8KT9d7OUmjMHtSV99zj6uLjMlLYgnI+YdaWzDKrRPt1uO1VgNHHCMXb142YPAK n+zpPTNagQYqVUiCl8yQKIIFxSw/V5DpJfskNDuzy56ywF6uWikzX3ShS7tRkKhz9Fnwe10K9fl7k Xy8B24gWWrXC8/LkXWhg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uQF0O-00000000PDG-2ulk; Sat, 14 Jun 2025 00:44:20 +0000 Received: from out-187.mta1.migadu.com ([95.215.58.187]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uQF0M-00000000PCp-22Gq; Sat, 14 Jun 2025 00:44:19 +0000 Message-ID: <422c5677-48d1-41be-b128-595829c27167@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1749861853; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EXuSTcUn0J6P+iqyqyqHY+kzA3pvndl/3kAQ7RECPmE=; b=u/e9RR/rxfXPFPycnlPVQqNrU5k0V5o6T4a0vCElbgKU5CYulJQONn820Lt+bxrHKt3EJj 9HC0jaQ//KBjncZGpnjDfEzSqPcZs914149pSwPRty719isCXS245ZnwGFUdJjeAcsJvWy YIWig0jncgm0xUQ2x57lRJYqQf2oUeE= Date: Fri, 13 Jun 2025 17:43:51 -0700 MIME-Version: 1.0 Subject: Re: [PATCH v2 06/12] RISC-V: KVM: Implement kvm_arch_flush_remote_tlbs_range() To: Anup Patel Cc: Palmer Dabbelt , Paul Walmsley , Alexandre Ghiti , Andrew Jones , Anup Patel , kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org References: <20250613065743.737102-1-apatel@ventanamicro.com> <20250613065743.737102-7-apatel@ventanamicro.com> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Atish Patra In-Reply-To: <20250613065743.737102-7-apatel@ventanamicro.com> X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250613_174418_746453_E9C70CD3 X-CRM114-Status: GOOD ( 17.63 ) X-BeenThere: kvm-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "kvm-riscv" Errors-To: kvm-riscv-bounces+kvm-riscv=archiver.kernel.org@lists.infradead.org On 6/12/25 11:57 PM, Anup Patel wrote: > The kvm_arch_flush_remote_tlbs_range() expected by KVM core can be > easily implemented for RISC-V using kvm_riscv_hfence_gvma_vmid_gpa() > hence provide it. > > Also with kvm_arch_flush_remote_tlbs_range() available for RISC-V, the > mmu_wp_memory_region() can happily use kvm_flush_remote_tlbs_memslot() > instead of kvm_flush_remote_tlbs(). > > Signed-off-by: Anup Patel > --- > arch/riscv/include/asm/kvm_host.h | 2 ++ > arch/riscv/kvm/mmu.c | 2 +- > arch/riscv/kvm/tlb.c | 8 ++++++++ > 3 files changed, 11 insertions(+), 1 deletion(-) > > diff --git a/arch/riscv/include/asm/kvm_host.h b/arch/riscv/include/asm/kvm_host.h > index ff1f76d6f177..6162575e2177 100644 > --- a/arch/riscv/include/asm/kvm_host.h > +++ b/arch/riscv/include/asm/kvm_host.h > @@ -43,6 +43,8 @@ > KVM_ARCH_REQ_FLAGS(5, KVM_REQUEST_WAIT | KVM_REQUEST_NO_WAKEUP) > #define KVM_REQ_STEAL_UPDATE KVM_ARCH_REQ(6) > > +#define __KVM_HAVE_ARCH_FLUSH_REMOTE_TLBS_RANGE > + > #define KVM_HEDELEG_DEFAULT (BIT(EXC_INST_MISALIGNED) | \ > BIT(EXC_BREAKPOINT) | \ > BIT(EXC_SYSCALL) | \ > diff --git a/arch/riscv/kvm/mmu.c b/arch/riscv/kvm/mmu.c > index 29f1bd853a66..a5387927a1c1 100644 > --- a/arch/riscv/kvm/mmu.c > +++ b/arch/riscv/kvm/mmu.c > @@ -344,7 +344,7 @@ static void gstage_wp_memory_region(struct kvm *kvm, int slot) > spin_lock(&kvm->mmu_lock); > gstage_wp_range(kvm, start, end); > spin_unlock(&kvm->mmu_lock); > - kvm_flush_remote_tlbs(kvm); > + kvm_flush_remote_tlbs_memslot(kvm, memslot); > } > > int kvm_riscv_gstage_ioremap(struct kvm *kvm, gpa_t gpa, > diff --git a/arch/riscv/kvm/tlb.c b/arch/riscv/kvm/tlb.c > index da98ca801d31..f46a27658c2e 100644 > --- a/arch/riscv/kvm/tlb.c > +++ b/arch/riscv/kvm/tlb.c > @@ -403,3 +403,11 @@ void kvm_riscv_hfence_vvma_all(struct kvm *kvm, > make_xfence_request(kvm, hbase, hmask, KVM_REQ_HFENCE_VVMA_ALL, > KVM_REQ_HFENCE_VVMA_ALL, NULL); > } > + > +int kvm_arch_flush_remote_tlbs_range(struct kvm *kvm, gfn_t gfn, u64 nr_pages) > +{ > + kvm_riscv_hfence_gvma_vmid_gpa(kvm, -1UL, 0, > + gfn << PAGE_SHIFT, nr_pages << PAGE_SHIFT, > + PAGE_SHIFT); > + return 0; > +} LGTM. However, I noticed that kvm_flush_remote_tlbs_range doesn't increment remote_tlb_flush_requests/remote_tlb_flush stat counter. So we would be losing those stats here. Do you know if there is a specific reason behind not supporting the stat counters in the *tlbs_range function ? Otherwise, Reviewed-by: Atish Patra -- kvm-riscv mailing list kvm-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kvm-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-180.mta1.migadu.com (out-180.mta1.migadu.com [95.215.58.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC2B6BA50 for ; Sat, 14 Jun 2025 00:44:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749861865; cv=none; b=ERQxaoCrU1+bVYGnK3nmyLGVw1581NGrHaPPNI2H0ULL3sqjIQVUhdZNgLx2sGRucPj6TAAZFl2G1gh1AXcFpHBjNlht0Ajrq0vtLsd+Ek53CY4q3OFfu6SGNN5/EZ3Iynt1EDIRJ+OU11UCT53zF0Ia+2HvDD0MOT8IUfEwcBc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749861865; c=relaxed/simple; bh=29cRgpEIn9i77ft2ErJCGJTeGJHKAHEj16jzFLOkDO8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=AOOFC/PdvJzAgB5cfr0PBVtv+7ikg4TtOlWGdupzKNflLqqtErmYgI0ZcqBBY6+Nv6L43OW+9XnzScNIbyNuzoYHFEMgfSFAHNzvXFLGtBIUcGzBchD3ZN3DLkJJZhlqHtTwX/KQrTPhrBKRvsdjhdmid8IG0ZlxW3sbO6Q493w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=u/e9RR/r; arc=none smtp.client-ip=95.215.58.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="u/e9RR/r" Message-ID: <422c5677-48d1-41be-b128-595829c27167@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1749861853; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EXuSTcUn0J6P+iqyqyqHY+kzA3pvndl/3kAQ7RECPmE=; b=u/e9RR/rxfXPFPycnlPVQqNrU5k0V5o6T4a0vCElbgKU5CYulJQONn820Lt+bxrHKt3EJj 9HC0jaQ//KBjncZGpnjDfEzSqPcZs914149pSwPRty719isCXS245ZnwGFUdJjeAcsJvWy YIWig0jncgm0xUQ2x57lRJYqQf2oUeE= Date: Fri, 13 Jun 2025 17:43:51 -0700 Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH v2 06/12] RISC-V: KVM: Implement kvm_arch_flush_remote_tlbs_range() To: Anup Patel Cc: Palmer Dabbelt , Paul Walmsley , Alexandre Ghiti , Andrew Jones , Anup Patel , kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org References: <20250613065743.737102-1-apatel@ventanamicro.com> <20250613065743.737102-7-apatel@ventanamicro.com> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Atish Patra In-Reply-To: <20250613065743.737102-7-apatel@ventanamicro.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 6/12/25 11:57 PM, Anup Patel wrote: > The kvm_arch_flush_remote_tlbs_range() expected by KVM core can be > easily implemented for RISC-V using kvm_riscv_hfence_gvma_vmid_gpa() > hence provide it. > > Also with kvm_arch_flush_remote_tlbs_range() available for RISC-V, the > mmu_wp_memory_region() can happily use kvm_flush_remote_tlbs_memslot() > instead of kvm_flush_remote_tlbs(). > > Signed-off-by: Anup Patel > --- > arch/riscv/include/asm/kvm_host.h | 2 ++ > arch/riscv/kvm/mmu.c | 2 +- > arch/riscv/kvm/tlb.c | 8 ++++++++ > 3 files changed, 11 insertions(+), 1 deletion(-) > > diff --git a/arch/riscv/include/asm/kvm_host.h b/arch/riscv/include/asm/kvm_host.h > index ff1f76d6f177..6162575e2177 100644 > --- a/arch/riscv/include/asm/kvm_host.h > +++ b/arch/riscv/include/asm/kvm_host.h > @@ -43,6 +43,8 @@ > KVM_ARCH_REQ_FLAGS(5, KVM_REQUEST_WAIT | KVM_REQUEST_NO_WAKEUP) > #define KVM_REQ_STEAL_UPDATE KVM_ARCH_REQ(6) > > +#define __KVM_HAVE_ARCH_FLUSH_REMOTE_TLBS_RANGE > + > #define KVM_HEDELEG_DEFAULT (BIT(EXC_INST_MISALIGNED) | \ > BIT(EXC_BREAKPOINT) | \ > BIT(EXC_SYSCALL) | \ > diff --git a/arch/riscv/kvm/mmu.c b/arch/riscv/kvm/mmu.c > index 29f1bd853a66..a5387927a1c1 100644 > --- a/arch/riscv/kvm/mmu.c > +++ b/arch/riscv/kvm/mmu.c > @@ -344,7 +344,7 @@ static void gstage_wp_memory_region(struct kvm *kvm, int slot) > spin_lock(&kvm->mmu_lock); > gstage_wp_range(kvm, start, end); > spin_unlock(&kvm->mmu_lock); > - kvm_flush_remote_tlbs(kvm); > + kvm_flush_remote_tlbs_memslot(kvm, memslot); > } > > int kvm_riscv_gstage_ioremap(struct kvm *kvm, gpa_t gpa, > diff --git a/arch/riscv/kvm/tlb.c b/arch/riscv/kvm/tlb.c > index da98ca801d31..f46a27658c2e 100644 > --- a/arch/riscv/kvm/tlb.c > +++ b/arch/riscv/kvm/tlb.c > @@ -403,3 +403,11 @@ void kvm_riscv_hfence_vvma_all(struct kvm *kvm, > make_xfence_request(kvm, hbase, hmask, KVM_REQ_HFENCE_VVMA_ALL, > KVM_REQ_HFENCE_VVMA_ALL, NULL); > } > + > +int kvm_arch_flush_remote_tlbs_range(struct kvm *kvm, gfn_t gfn, u64 nr_pages) > +{ > + kvm_riscv_hfence_gvma_vmid_gpa(kvm, -1UL, 0, > + gfn << PAGE_SHIFT, nr_pages << PAGE_SHIFT, > + PAGE_SHIFT); > + return 0; > +} LGTM. However, I noticed that kvm_flush_remote_tlbs_range doesn't increment remote_tlb_flush_requests/remote_tlb_flush stat counter. So we would be losing those stats here. Do you know if there is a specific reason behind not supporting the stat counters in the *tlbs_range function ? Otherwise, Reviewed-by: Atish Patra From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9970BC71136 for ; Sat, 14 Jun 2025 00:44:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SHmxeY5/fcONsrKhZdNyA8lLNvwz9T3dJ6mBejKaC6s=; b=ccaOAQ0ubrwwqU I7ySNGwKdST8h/vayxhcRlZmv5bACDi335ISxwHja4f9PX9Se/iGpsEjkI2tAgJoTgZHEYnuYwtnF XR+JlMacPmJQEizaXhv4Kk2sefvx+Ah/675mpV1GOYSli+bhhq26WARsjmFmZqFQPSMQVgOZWyq1V qsbgOJQqGWH9FiUcBUWdAa4s30/u8hTvSNYQAJOjn26WVHLtsIULxCFzQ4zxvcRM2AGqsNXDB3j7h AA7GRA2w8htMVri4n3nPe6J3oftqgAGDfDRZIyEUP0lbnSmbYEZB91SAriuAOGkNb5amukuxR/nib uUWgR0YU5T7A7NI0lNPA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uQF0P-00000000PDP-049c; Sat, 14 Jun 2025 00:44:21 +0000 Received: from out-187.mta1.migadu.com ([95.215.58.187]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uQF0M-00000000PCp-22Gq; Sat, 14 Jun 2025 00:44:19 +0000 Message-ID: <422c5677-48d1-41be-b128-595829c27167@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1749861853; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EXuSTcUn0J6P+iqyqyqHY+kzA3pvndl/3kAQ7RECPmE=; b=u/e9RR/rxfXPFPycnlPVQqNrU5k0V5o6T4a0vCElbgKU5CYulJQONn820Lt+bxrHKt3EJj 9HC0jaQ//KBjncZGpnjDfEzSqPcZs914149pSwPRty719isCXS245ZnwGFUdJjeAcsJvWy YIWig0jncgm0xUQ2x57lRJYqQf2oUeE= Date: Fri, 13 Jun 2025 17:43:51 -0700 MIME-Version: 1.0 Subject: Re: [PATCH v2 06/12] RISC-V: KVM: Implement kvm_arch_flush_remote_tlbs_range() To: Anup Patel Cc: Palmer Dabbelt , Paul Walmsley , Alexandre Ghiti , Andrew Jones , Anup Patel , kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org References: <20250613065743.737102-1-apatel@ventanamicro.com> <20250613065743.737102-7-apatel@ventanamicro.com> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Atish Patra In-Reply-To: <20250613065743.737102-7-apatel@ventanamicro.com> X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250613_174418_746453_E9C70CD3 X-CRM114-Status: GOOD ( 17.63 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On 6/12/25 11:57 PM, Anup Patel wrote: > The kvm_arch_flush_remote_tlbs_range() expected by KVM core can be > easily implemented for RISC-V using kvm_riscv_hfence_gvma_vmid_gpa() > hence provide it. > > Also with kvm_arch_flush_remote_tlbs_range() available for RISC-V, the > mmu_wp_memory_region() can happily use kvm_flush_remote_tlbs_memslot() > instead of kvm_flush_remote_tlbs(). > > Signed-off-by: Anup Patel > --- > arch/riscv/include/asm/kvm_host.h | 2 ++ > arch/riscv/kvm/mmu.c | 2 +- > arch/riscv/kvm/tlb.c | 8 ++++++++ > 3 files changed, 11 insertions(+), 1 deletion(-) > > diff --git a/arch/riscv/include/asm/kvm_host.h b/arch/riscv/include/asm/kvm_host.h > index ff1f76d6f177..6162575e2177 100644 > --- a/arch/riscv/include/asm/kvm_host.h > +++ b/arch/riscv/include/asm/kvm_host.h > @@ -43,6 +43,8 @@ > KVM_ARCH_REQ_FLAGS(5, KVM_REQUEST_WAIT | KVM_REQUEST_NO_WAKEUP) > #define KVM_REQ_STEAL_UPDATE KVM_ARCH_REQ(6) > > +#define __KVM_HAVE_ARCH_FLUSH_REMOTE_TLBS_RANGE > + > #define KVM_HEDELEG_DEFAULT (BIT(EXC_INST_MISALIGNED) | \ > BIT(EXC_BREAKPOINT) | \ > BIT(EXC_SYSCALL) | \ > diff --git a/arch/riscv/kvm/mmu.c b/arch/riscv/kvm/mmu.c > index 29f1bd853a66..a5387927a1c1 100644 > --- a/arch/riscv/kvm/mmu.c > +++ b/arch/riscv/kvm/mmu.c > @@ -344,7 +344,7 @@ static void gstage_wp_memory_region(struct kvm *kvm, int slot) > spin_lock(&kvm->mmu_lock); > gstage_wp_range(kvm, start, end); > spin_unlock(&kvm->mmu_lock); > - kvm_flush_remote_tlbs(kvm); > + kvm_flush_remote_tlbs_memslot(kvm, memslot); > } > > int kvm_riscv_gstage_ioremap(struct kvm *kvm, gpa_t gpa, > diff --git a/arch/riscv/kvm/tlb.c b/arch/riscv/kvm/tlb.c > index da98ca801d31..f46a27658c2e 100644 > --- a/arch/riscv/kvm/tlb.c > +++ b/arch/riscv/kvm/tlb.c > @@ -403,3 +403,11 @@ void kvm_riscv_hfence_vvma_all(struct kvm *kvm, > make_xfence_request(kvm, hbase, hmask, KVM_REQ_HFENCE_VVMA_ALL, > KVM_REQ_HFENCE_VVMA_ALL, NULL); > } > + > +int kvm_arch_flush_remote_tlbs_range(struct kvm *kvm, gfn_t gfn, u64 nr_pages) > +{ > + kvm_riscv_hfence_gvma_vmid_gpa(kvm, -1UL, 0, > + gfn << PAGE_SHIFT, nr_pages << PAGE_SHIFT, > + PAGE_SHIFT); > + return 0; > +} LGTM. However, I noticed that kvm_flush_remote_tlbs_range doesn't increment remote_tlb_flush_requests/remote_tlb_flush stat counter. So we would be losing those stats here. Do you know if there is a specific reason behind not supporting the stat counters in the *tlbs_range function ? Otherwise, Reviewed-by: Atish Patra _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv