From: Jeff Garzik <jgarzik@pobox.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: Andrew Morton <akpm@zip.com.au>,
kernel list <linux-kernel@vger.kernel.org>,
linux-net@vger.kernel.org
Subject: Re: Fix suspend/resume on via-velocity
Date: Fri, 11 Mar 2005 14:33:21 -0500 [thread overview]
Message-ID: <4231F281.8060202@pobox.com> (raw)
In-Reply-To: <20050311141132.GA1539@elf.ucw.cz>
Pavel Machek wrote:
> Hi!
>
> This fixes suspend-resume on via-velocity. It was confused
> w.r.t. pointers... Please apply,
>
> Signed-off-by: Pavel Machek <pavel@suse.cz>
> Pavel
>
> --- clean-mm/drivers/net/via-velocity.c 2005-03-11 11:25:36.000000000 +0100
> +++ linux/drivers/net/via-velocity.c 2005-03-11 10:06:05.000000000 +0100
> @@ -3212,7 +3212,8 @@
>
> static int velocity_suspend(struct pci_dev *pdev, pm_message_t state)
> {
> - struct velocity_info *vptr = pci_get_drvdata(pdev);
> + struct net_device *dev = pci_get_drvdata(pdev);
> + struct velocity_info *vptr = dev->priv;
> unsigned long flags;
>
> if(!netif_running(vptr->dev))
> @@ -3245,7 +3246,8 @@
>
> static int velocity_resume(struct pci_dev *pdev)
> {
> - struct velocity_info *vptr = pci_get_drvdata(pdev);
> + struct net_device *dev = pci_get_drvdata(pdev);
> + struct velocity_info *vptr = dev->priv;
Please use netdev_priv() rather than 'dev->priv', to eliminate a
dereference.
Jeff
next prev parent reply other threads:[~2005-03-11 19:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-11 14:11 Fix suspend/resume on via-velocity Pavel Machek
2005-03-11 19:33 ` Jeff Garzik [this message]
2005-03-12 19:11 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4231F281.8060202@pobox.com \
--to=jgarzik@pobox.com \
--cc=akpm@zip.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.