From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH RFC 6/9] drm/omap: dss: Move platform_device_register from core.c to dss.c probe Date: Tue, 27 Feb 2018 16:46:40 +0200 Message-ID: <4235558.Q8LYdxuuu4@avalon> References: Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from galahad.ideasonboard.com (galahad.ideasonboard.com [185.26.127.97]) by gabe.freedesktop.org (Postfix) with ESMTPS id A4C216E6DC for ; Tue, 27 Feb 2018 14:45:51 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jyri Sarha Cc: tomi.valkeinen@ti.com, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SGkgSnlyaSwKClRoYW5rIHlvdSBmb3IgdGhlIHBhdGNoLgoKT24gRnJpZGF5LCAxNiBGZWJydWFy eSAyMDE4IDEzOjI1OjA3IEVFVCBKeXJpIFNhcmhhIHdyb3RlOgo+IFJlZ2lzdGVyIHRoZSBvbWFw ZHJtIGRldmljZSB3aGVuIHdlIGtub3cgdGhhdCBkc3MgZGV2aWNlIHByb2JlIGdvaW5nCj4gdG8g c3VjY2VlZC4gVGhpcyBhdm9pZHMgRFNTNiBhbmQgRFNTMiBvbWFwZHJtIGRldmljZSByZWdpc3Ry YXRpb24gZnJvbQo+IGNvbGxpZGluZyB3aXRoIGVhY2ggb3RoZXIuCj4gCj4gU2lnbmVkLW9mZi1i eTogSnlyaSBTYXJoYSA8anNhcmhhQHRpLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL29t YXBkcm0vZHNzL2NvcmUuYyB8IDI2ICsrLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4gIGRyaXZl cnMvZ3B1L2RybS9vbWFwZHJtL2Rzcy9kc3MuYyAgfCAxOSArKysrKysrKysrKysrKysrKysrCj4g IDIgZmlsZXMgY2hhbmdlZCwgMjEgaW5zZXJ0aW9ucygrKSwgMjQgZGVsZXRpb25zKC0pCj4gCj4g ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9vbWFwZHJtL2Rzcy9jb3JlLmMKPiBiL2RyaXZl cnMvZ3B1L2RybS9vbWFwZHJtL2Rzcy9jb3JlLmMgaW5kZXggYWNlZjdlYy4uNmM5ZjY2NyAxMDA2 NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vb21hcGRybS9kc3MvY29yZS5jCj4gKysrIGIvZHJp dmVycy9ncHUvZHJtL29tYXBkcm0vZHNzL2NvcmUuYwo+IEBAIC00NSwzNiArNDUsMTQgQEAgc3Rh dGljIHN0cnVjdCBwbGF0Zm9ybV9kcml2ZXIgKiBjb25zdCBvbWFwX2Rzc19kcml2ZXJzW10KPiA9 IHsgI2VuZGlmCj4gIH07Cj4gCj4gLXN0YXRpYyBzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpvbWFw X2RybV9kZXZpY2U7Cj4gLQo+ICBzdGF0aWMgaW50IF9faW5pdCBvbWFwX2Rzc19pbml0KHZvaWQp Cj4gIHsKPiAtCWludCByOwo+IC0KPiAtCXIgPSBwbGF0Zm9ybV9yZWdpc3Rlcl9kcml2ZXJzKG9t YXBfZHNzX2RyaXZlcnMsCj4gLQkJCQkgICAgICBBUlJBWV9TSVpFKG9tYXBfZHNzX2RyaXZlcnMp KTsKPiAtCWlmIChyKQo+IC0JCWdvdG8gZXJyX3JlZzsKPiAtCj4gLQlvbWFwX2RybV9kZXZpY2Ug PSBwbGF0Zm9ybV9kZXZpY2VfcmVnaXN0ZXJfc2ltcGxlKCJvbWFwZHJtIiwgMCwgTlVMTCwgMCk7 Cj4gLQlpZiAoSVNfRVJSKG9tYXBfZHJtX2RldmljZSkpIHsKPiAtCQlyID0gUFRSX0VSUihvbWFw X2RybV9kZXZpY2UpOwo+IC0JCWdvdG8gZXJyX3JlZzsKPiAtCX0KPiAtCj4gLQlyZXR1cm4gMDsK PiAtCj4gLWVycl9yZWc6Cj4gLQlwbGF0Zm9ybV91bnJlZ2lzdGVyX2RyaXZlcnMob21hcF9kc3Nf ZHJpdmVycywKPiAtCQkJCSAgICBBUlJBWV9TSVpFKG9tYXBfZHNzX2RyaXZlcnMpKTsKPiAtCj4g LQlyZXR1cm4gcjsKPiArCXJldHVybiBwbGF0Zm9ybV9yZWdpc3Rlcl9kcml2ZXJzKG9tYXBfZHNz X2RyaXZlcnMsCj4gKwkJCQkJIEFSUkFZX1NJWkUob21hcF9kc3NfZHJpdmVycykpOwo+ICB9Cj4g Cj4gIHN0YXRpYyB2b2lkIF9fZXhpdCBvbWFwX2Rzc19leGl0KHZvaWQpCj4gIHsKPiAtCXBsYXRm b3JtX2RldmljZV91bnJlZ2lzdGVyKG9tYXBfZHJtX2RldmljZSk7Cj4gLQo+ICAJcGxhdGZvcm1f dW5yZWdpc3Rlcl9kcml2ZXJzKG9tYXBfZHNzX2RyaXZlcnMsCj4gIAkJCQkgICAgQVJSQVlfU0la RShvbWFwX2Rzc19kcml2ZXJzKSk7Cj4gIH0KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt L29tYXBkcm0vZHNzL2Rzcy5jCj4gYi9kcml2ZXJzL2dwdS9kcm0vb21hcGRybS9kc3MvZHNzLmMg aW5kZXggNTc1MjMyOC4uZGRhMzIzNyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vb21h cGRybS9kc3MvZHNzLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vb21hcGRybS9kc3MvZHNzLmMK PiBAQCAtMTMxNCw2ICsxMzE0LDE3IEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3Qgc29jX2RldmljZV9h dHRyaWJ1dGUKPiBkc3Nfc29jX2RldmljZXNbXSA9IHsgeyAvKiBzZW50aW5lbCAqLyB9Cj4gIH07 Cj4gCj4gK3N0YXRpYyBzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpvbWFwX2RybV9kZXZpY2U7CgpM ZXQncyBzdG9yZSB0aGlzIGluIHRoZSBkc3NfZGV2aWNlIHN0cnVjdHVyZSBpbnN0ZWFkIG9mIGFk ZGluZyBhIG5ldyBnbG9iYWwgCnZhcmlhYmxlLiBJJ3ZlIHNwZW50IGVub3VnaCB0aW1lIGNoYXNp bmcgdGhlIGdsb2JhbHMsIEkgZG9uJ3Qgd2FudCBhbnkgbmV3IG9uZSAKOi0pCgo+ICtzdGF0aWMg aW50IGluaXRpYWxpemVfb21hcGRybV9kZXZpY2Uodm9pZCkKPiArewo+ICsJb21hcF9kcm1fZGV2 aWNlID0gcGxhdGZvcm1fZGV2aWNlX3JlZ2lzdGVyX3NpbXBsZSgib21hcGRybSIsIDAsIE5VTEws IDApOwo+ICsJaWYgKElTX0VSUihvbWFwX2RybV9kZXZpY2UpKQo+ICsJCXJldHVybiBQVFJfRVJS KG9tYXBfZHJtX2RldmljZSk7Cj4gKwo+ICsJcmV0dXJuIDA7Cj4gK30KPiArCj4gIHN0YXRpYyBp bnQgZHNzX2JpbmQoc3RydWN0IGRldmljZSAqZGV2KQo+ICB7Cj4gIAlzdHJ1Y3QgZHNzX2Rldmlj ZSAqZHNzID0gZGV2X2dldF9kcnZkYXRhKGRldik7Cj4gQEAgLTEzMjMsNiArMTMzNCwxMiBAQCBz dGF0aWMgaW50IGRzc19iaW5kKHN0cnVjdCBkZXZpY2UgKmRldikKPiAgCWlmIChyKQo+ICAJCXJl dHVybiByOwo+IAo+ICsJciA9IGluaXRpYWxpemVfb21hcGRybV9kZXZpY2UoKTsKPiArCWlmIChy KSB7Cj4gKwkJY29tcG9uZW50X3VuYmluZF9hbGwoZGV2LCBOVUxMKTsKPiArCQlyZXR1cm4gcjsK PiArCX0KPiArCgpTaG91bGQgdGhpcyBiZSBjYWxsZWQgYWZ0ZXIgb21hcGRzc19nYXRoZXJfY29t cG9uZW50cygpIGFuZCBvbWFwZHNzX3NldF9kc3MoKSAKdG8gbWFrZSBzdXJlIHRoZSBvbWFwZHJt IHByb2JlIHdvbid0IGJlIGRlZmVycmVkIGJ5IHRoZSBEU1Mgbm90IGJlaW5nIAppbml0aWFsaXpl ZCA/Cgo+ICAJcG1fc2V0X3Z0X3N3aXRjaCgwKTsKPiAKPiAgCW9tYXBkc3NfZ2F0aGVyX2NvbXBv bmVudHMoZGV2KTsKPiBAQCAtMTMzNSw2ICsxMzUyLDggQEAgc3RhdGljIHZvaWQgZHNzX3VuYmlu ZChzdHJ1Y3QgZGV2aWNlICpkZXYpCj4gIHsKPiAgCW9tYXBkc3Nfc2V0X2RzcyhOVUxMKTsKPiAK PiArCXBsYXRmb3JtX2RldmljZV91bnJlZ2lzdGVyKG9tYXBfZHJtX2RldmljZSk7Cj4gKwoKU2Ft ZSBoZXJlLCBzaG91bGQgdGhpcyBiZSBjYWxsZWQgYmVmb3JlIG9tYXBkc3Nfc2V0X2RzcygpIGZv ciBzeW1tZXRyeSA/Cgo+ICAJY29tcG9uZW50X3VuYmluZF9hbGwoZGV2LCBOVUxMKTsKPiAgfQoK LS0gClJlZ2FyZHMsCgpMYXVyZW50IFBpbmNoYXJ0CgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h bi9saXN0aW5mby9kcmktZGV2ZWwK