All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lars Grunewaldt <lgw@dark-reality.de>
To: bluez-devel@lists.sourceforge.net
Subject: Re: [Bluez-devel] Re: [Patch] Some btsco modifications
Date: Mon, 14 Mar 2005 12:52:40 +0100	[thread overview]
Message-ID: <42357B08.7020009@dark-reality.de> (raw)
In-Reply-To: <1110762698.5056.73.camel@pc7.dolda2000.com>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


|>>On the bad side, the coding is pretty unelegant in its places, and I've
|>>completely violated your coding style. Also, backward compatibility for
|>>userspace communication is broken since I had to extend the structure
|>>for incorporating usage status. I haven't updated the btsco2 program
|>>either.

I really like the changes you made in this patch, but why don't you
simply follow the coding style and send in a patch that's actually
usefull to the community? It's not that hard to comply to coding
style...? *scratchinghishead*

maybe you could fix the coding style and send it in again :)

Is it possible to have the headset buttons work as they did without the
patch, like, switching between both behaviours? there are scenarios for
both methods, and even the BT specs cover both of them.

best regards & thanks for helping out,
~  Lars

- --
Lars Grunewaldt
* software development
* multimedia design
skills: C/C++/Java/PHP/(X)HTML/Flash/audio/video
web: http://www.dark-reality.de
mail: lgw@dark-reality.de
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFCNXsHQWC6DTWkDAoRAty+AJ9aa55eTNBHLL9A5xgTzwVT6c7lmACfQ5mm
+Nw6fldrnKKJlRGwHV7qLkc=
=nWCb
-----END PGP SIGNATURE-----


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

  reply	other threads:[~2005-03-14 11:52 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1110683934.5056.43.camel@pc7.dolda2000.com>
     [not found] ` <4233C663.80109@xmission.com>
2005-03-14  1:11   ` [Bluez-devel] Re: [Patch] Some btsco modifications Fredrik Tolf
2005-03-14 11:52     ` Lars Grunewaldt [this message]
2005-03-14 13:51       ` Fredrik Tolf
2005-03-14 15:00         ` Fredrik Tolf
2005-03-14 12:55     ` Brad Midgley
2005-03-14 14:05       ` Fredrik Tolf
2005-03-14 17:26         ` Brad Midgley
2005-03-14 19:01           ` Florian Echtler
2005-03-14 20:34             ` Brad Midgley
2005-03-15  7:22         ` Brad Midgley
2005-03-15 23:42           ` Fredrik Tolf
2005-03-16  0:17             ` Brad Midgley
2005-03-16  1:56               ` Fredrik Tolf
2005-03-16 12:30                 ` Lars Grunewaldt
2005-03-16 13:01                   ` Fredrik Tolf
2005-03-16 15:18                     ` Brad Midgley
2005-03-16 19:34                     ` Lars Grunewaldt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42357B08.7020009@dark-reality.de \
    --to=lgw@dark-reality.de \
    --cc=bluez-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.