All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Dumazet <dada1@cosmosbay.com>
To: unlisted-recipients:; (no To-header on input)
Cc: linux-kernel@vger.kernel.org, vda@port.imtp.ilyichevsk.odessa.ua
Subject: x86: spin_unlock(), spin_unlock_irq() & others are out of line ?
Date: Tue, 15 Mar 2005 11:48:39 +0100	[thread overview]
Message-ID: <4236BD87.6000408@cosmosbay.com> (raw)
In-Reply-To: <20050314193447.47ca6754.akpm@osdl.org>

Hi all

I noticed that in current linux kernel versions (2.6.11), some basic 
functions are out of line (not inlined)

Example of a call to spin_unlock(&somelock)
c01069fa:   b8 e8 7b 35 c0          mov    $0xc0357be8,%eax
c01069ff:   e8 3c e4 1f 00          call   c0304e40 <_spin_unlock>


c0304e40 <_spin_unlock>:
c0304e40:   c6 00 01                movb   $0x1,(%eax)
c0304e43:   c3                      ret


Same problem for _write_unlock(), _read_unlock(), _spin_unlock_irq(), ...

That seems odd, and I fail to see the reason for that. (It's OK for 
complex functions, but not for very short ones...)

Is it a regression, or is it needed ?

configuration :
	- SMP
	- Processor family (Pentium-4/Celeron(P4-based)/Pentium-4 M/Xeon)
	- No "Generic x86 support"

Thank you
Eric Dumazet


  reply	other threads:[~2005-03-15 10:48 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-13 18:20 [patch] x86: fix ESP corruption CPU bug Stas Sergeev
2005-03-13 18:52 ` Grzegorz Kulewski
2005-03-13 19:11   ` Stas Sergeev
2005-03-13 19:37     ` Ondrej Zary
2005-03-13 19:46       ` Stas Sergeev
2005-03-13 20:02   ` Pavel Machek
2005-03-13 20:10 ` Pavel Machek
2005-03-13 20:55   ` Stas Sergeev
2005-03-13 21:13     ` Linus Torvalds
2005-03-13 22:06       ` [patch] x86: fix ESP corruption CPU bug (take 2) Stas Sergeev
2005-03-14 19:29         ` Alan Cox
2005-03-14 19:59           ` Stas Sergeev
2005-03-15  3:34             ` Andrew Morton
2005-03-15 10:48               ` Eric Dumazet [this message]
2005-03-15 19:44                 ` x86: spin_unlock(), spin_unlock_irq() & others are out of line ? Lee Revell
2005-03-15 19:48               ` [patch] x86: fix ESP corruption CPU bug (take 2) Stas Sergeev
2005-03-13 23:17       ` [patch] x86: fix ESP corruption CPU bug Pavel Machek
2005-03-13 23:54         ` Linus Torvalds
2005-03-14  0:16       ` Linus Torvalds
2005-03-14  4:52         ` Stas Sergeev
2005-03-14  9:34           ` Andi Kleen
2005-03-14 10:37             ` [BUG?] x86_64 : Can not read /dev/kmem ? Eric Dumazet
2005-03-21 19:37               ` Andi Kleen
2005-03-22 15:24               ` Andi Kleen
2005-03-14 15:21             ` [patch] x86: fix ESP corruption CPU bug Jakob Eriksson
2005-03-14 17:03               ` linux-os
2005-03-14 17:10                 ` Pavel Machek
2005-03-14 19:24                 ` Brian Gerst
2005-03-14 20:21                   ` Stas Sergeev
2005-03-14 18:02               ` Stas Sergeev
2005-03-14 17:29             ` Stas Sergeev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4236BD87.6000408@cosmosbay.com \
    --to=dada1@cosmosbay.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vda@port.imtp.ilyichevsk.odessa.ua \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.