All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Yasuyuki KOZAKAI <yasuyuki.kozakai@toshiba.co.jp>
Cc: netfilter-devel@lists.netfilter.org, usagi-core@linux-ipv6.org
Subject: Re: nf_conntrack tree
Date: Wed, 16 Mar 2005 21:04:06 +0100	[thread overview]
Message-ID: <42389136.3050900@trash.net> (raw)
In-Reply-To: <200503161954.j2GJsIhi017839@toshiba.co.jp>

Yasuyuki KOZAKAI wrote:
>>That won't work when nf_conntrack is already loaded. Do you think
>>it is necessary to allow people to build both as modules?
> 
> 
> You're right. #ifdef or other staff is needed.

If we go the way Joszef propsed, namely having something like
a global struct nf_ct_ops *, we can simply add a flag to it
which specifies which conntrack is usec.

>>                                                          It would
>>be easier to just force them to choose, and would probably result
>>in more people actually using it since ip_conntrack wouldn't be used
>>by default anymore.
> 
> But I want this flexibility if possible so that we can test matches/targets
> with ip_conntrack/nf_conntrack without recompiling.

I see that it would be useful for testing, but I fear that it will
result in additional complexity and bugs with little gain for users.
Let's see how it works out, if it really does cause a lot of extra
complexity it would prefer to only allow one at a time.

Regards
Patrick

  reply	other threads:[~2005-03-16 20:04 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-23  6:17 [PATCH NF_CONNTRACK 1/9]: Fix multiple problems with TCP window tracking Yasuyuki KOZAKAI
2005-05-23 13:46 ` Michal Rokos
2005-03-16  0:35   ` nf_conntrack tree Patrick McHardy
2005-03-16  6:48     ` Yasuyuki KOZAKAI
2005-03-16  9:53       ` Pablo Neira
2005-03-16 10:13         ` Jozsef Kadlecsik
2005-03-16 13:14           ` Yasuyuki KOZAKAI
2005-03-16 14:36           ` Patrick McHardy
2005-03-16 14:31       ` Patrick McHardy
     [not found]     ` <200503160648.j2G6mXVV014699@toshiba.co.jp>
2005-03-16 19:22       ` Yasuyuki KOZAKAI
2005-03-16 19:32         ` Patrick McHardy
2005-03-16 19:54           ` Yasuyuki KOZAKAI
2005-03-16 20:04             ` Patrick McHardy [this message]
2005-03-17  8:31               ` Yasuyuki KOZAKAI
2005-03-20 16:42                 ` Patrick McHardy
2005-03-22 16:31                   ` Yasuyuki KOZAKAI
2005-05-24  1:53     ` [PATCH NF_CONNTRACK 1/9]: Fix multiple problems with TCP window tracking Yasuyuki KOZAKAI
2005-06-11 15:42       ` Patrick McHardy
     [not found]   ` <200505240153.j4O1r35h028029@toshiba.co.jp>
2005-05-24 11:23     ` Michal Rokos
2005-06-11 15:49       ` Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42389136.3050900@trash.net \
    --to=kaber@trash.net \
    --cc=netfilter-devel@lists.netfilter.org \
    --cc=usagi-core@linux-ipv6.org \
    --cc=yasuyuki.kozakai@toshiba.co.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.