From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2] drivers/net:new PMD using tun/tap host interface Date: Wed, 21 Sep 2016 10:24:37 +0200 Message-ID: <4238923.20rfmTZejf@xps13> References: <1473948649-14169-1-git-send-email-keith.wiles@intel.com> <17C91FD1-D21A-49E3-B093-71AA5C1D79C6@intel.com> <20160921021351.GY23158@yliu-dev.sh.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Yuanhan Liu , "pmatilai@redhat.com" To: "Wiles, Keith" Return-path: Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41]) by dpdk.org (Postfix) with ESMTP id 6F634374F for ; Wed, 21 Sep 2016 10:24:39 +0200 (CEST) Received: by mail-wm0-f41.google.com with SMTP id d66so27564442wmf.0 for ; Wed, 21 Sep 2016 01:24:39 -0700 (PDT) In-Reply-To: <20160921021351.GY23158@yliu-dev.sh.intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-09-21 10:13, Yuanhan Liu: > On Wed, Sep 21, 2016 at 01:32:15AM +0000, Wiles, Keith wrote: > > I only assumed this to work for Linux and not FreeBSD/NetBSD as the handling of the opens on the tun device are different then linux. I also only added it to the common_linux configuration file. > > I didn't notice the common_linux file, but I have guessed so (that you > meant to enable linux only): the "ifdef __linux" stuff just confuses me > a bit. By the way, we have a macro for Linux environment: RTE_EXEC_ENV_LINUXAPP Please prefer it over __linux