From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D9F8DC433FE for ; Thu, 17 Nov 2022 11:26:21 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5BDDF10E59E; Thu, 17 Nov 2022 11:26:08 +0000 (UTC) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id D3B6E10E086; Thu, 17 Nov 2022 11:26:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1668684364; x=1700220364; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=wIhdk+ODh3SdPim6EYJThsglCh/rL6J3AMNR3/FxZbw=; b=AORIOgt2zilxZsf8aBt4Tqja2TV1gIsgqSUxI401KapZ+sA+gF867nIc A1eS92FonTbtCfcpAYjGbwwI/QzlMvZCBn+FSMIbxaXtKWfzEMT9cKE2R YDYYYnnzJCtufFDfvUFJVsnldrxp1xrA/iMNZV8tECy2X5ngSUvGwhLwl noRcLVRlBVNjDRdjjcFzkVE8NQ5Hp43PmGxkjr3o7UrZokqAVKfen9RQm mKUG0i4bUb+esuEnKAn46ypeQUN0PSsvZ/J68kdPQK2XUSPilUERF3V4Q Bcc6R5UXO4UFWjWTJg8TMJVyfulyYF1MRqA8YVZEGfCQWSFF1MUYP5Yr7 A==; X-IronPort-AV: E=McAfee;i="6500,9779,10533"; a="311530094" X-IronPort-AV: E=Sophos;i="5.96,171,1665471600"; d="scan'208";a="311530094" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Nov 2022 03:25:52 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10533"; a="639768415" X-IronPort-AV: E=Sophos;i="5.96,171,1665471600"; d="scan'208";a="639768415" Received: from respir1x-mobl1.ger.corp.intel.com (HELO [10.252.18.140]) ([10.252.18.140]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Nov 2022 03:25:51 -0800 Message-ID: <423905ec-1584-3035-7c9e-d118296b4d04@intel.com> Date: Thu, 17 Nov 2022 11:25:48 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.4.1 Content-Language: en-GB To: Nirmoy Das , intel-gfx@lists.freedesktop.org References: <20221013084007.19843-1-nirmoy.das@intel.com> <20221013084007.19843-2-nirmoy.das@intel.com> From: Matthew Auld In-Reply-To: <20221013084007.19843-2-nirmoy.das@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Intel-gfx] [PATCH 2/2] drm/i915: Ratelimit debug log in vm_fault_ttm X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 13/10/2022 09:40, Nirmoy Das wrote: > Test like i915_gem_mman_live_selftests/igt_mmap_migrate can cause > dmesg spamming. Use ratelimit api to reduce log rate. > > References: https://gitlab.freedesktop.org/drm/intel/-/issues/7038 > Cc: Matthew Auld > Signed-off-by: Nirmoy Das Reviewed-by: Matthew Auld > --- > drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c > index d63f30efd631..6b60b99461e2 100644 > --- a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c > +++ b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c > @@ -1080,8 +1080,9 @@ static vm_fault_t vm_fault_ttm(struct vm_fault *vmf) > } > > if (err) { > - drm_dbg(dev, "Unable to make resource CPU accessible(err = %pe)\n", > - ERR_PTR(err)); > + drm_dbg_ratelimited(dev, > + "Unable to make resource CPU accessible(err = %pe)\n", > + ERR_PTR(err)); > dma_resv_unlock(bo->base.resv); > ret = VM_FAULT_SIGBUS; > goto out_rpm; From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A5EB9C4332F for ; Thu, 17 Nov 2022 11:26:09 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1BA3C10E086; Thu, 17 Nov 2022 11:26:07 +0000 (UTC) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id D3B6E10E086; Thu, 17 Nov 2022 11:26:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1668684364; x=1700220364; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=wIhdk+ODh3SdPim6EYJThsglCh/rL6J3AMNR3/FxZbw=; b=AORIOgt2zilxZsf8aBt4Tqja2TV1gIsgqSUxI401KapZ+sA+gF867nIc A1eS92FonTbtCfcpAYjGbwwI/QzlMvZCBn+FSMIbxaXtKWfzEMT9cKE2R YDYYYnnzJCtufFDfvUFJVsnldrxp1xrA/iMNZV8tECy2X5ngSUvGwhLwl noRcLVRlBVNjDRdjjcFzkVE8NQ5Hp43PmGxkjr3o7UrZokqAVKfen9RQm mKUG0i4bUb+esuEnKAn46ypeQUN0PSsvZ/J68kdPQK2XUSPilUERF3V4Q Bcc6R5UXO4UFWjWTJg8TMJVyfulyYF1MRqA8YVZEGfCQWSFF1MUYP5Yr7 A==; X-IronPort-AV: E=McAfee;i="6500,9779,10533"; a="311530094" X-IronPort-AV: E=Sophos;i="5.96,171,1665471600"; d="scan'208";a="311530094" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Nov 2022 03:25:52 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10533"; a="639768415" X-IronPort-AV: E=Sophos;i="5.96,171,1665471600"; d="scan'208";a="639768415" Received: from respir1x-mobl1.ger.corp.intel.com (HELO [10.252.18.140]) ([10.252.18.140]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Nov 2022 03:25:51 -0800 Message-ID: <423905ec-1584-3035-7c9e-d118296b4d04@intel.com> Date: Thu, 17 Nov 2022 11:25:48 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.4.1 Subject: Re: [PATCH 2/2] drm/i915: Ratelimit debug log in vm_fault_ttm Content-Language: en-GB To: Nirmoy Das , intel-gfx@lists.freedesktop.org References: <20221013084007.19843-1-nirmoy.das@intel.com> <20221013084007.19843-2-nirmoy.das@intel.com> From: Matthew Auld In-Reply-To: <20221013084007.19843-2-nirmoy.das@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 13/10/2022 09:40, Nirmoy Das wrote: > Test like i915_gem_mman_live_selftests/igt_mmap_migrate can cause > dmesg spamming. Use ratelimit api to reduce log rate. > > References: https://gitlab.freedesktop.org/drm/intel/-/issues/7038 > Cc: Matthew Auld > Signed-off-by: Nirmoy Das Reviewed-by: Matthew Auld > --- > drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c > index d63f30efd631..6b60b99461e2 100644 > --- a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c > +++ b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c > @@ -1080,8 +1080,9 @@ static vm_fault_t vm_fault_ttm(struct vm_fault *vmf) > } > > if (err) { > - drm_dbg(dev, "Unable to make resource CPU accessible(err = %pe)\n", > - ERR_PTR(err)); > + drm_dbg_ratelimited(dev, > + "Unable to make resource CPU accessible(err = %pe)\n", > + ERR_PTR(err)); > dma_resv_unlock(bo->base.resv); > ret = VM_FAULT_SIGBUS; > goto out_rpm;