All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tommi Virtanen <tv@tv.debian.net>
To: Kurt Garloff <garloff@suse.de>
Cc: Xen development list <xen-devel@lists.sourceforge.net>,
	Philip R Auld <pauld@egenera.com>,
	David Hopwood <david.hopwood@blueyonder.co.uk>
Subject: Re: severe security issue on dom0/xend/xm/non-root users
Date: Fri, 18 Mar 2005 13:59:57 +0200	[thread overview]
Message-ID: <423AC2BD.10601@tv.debian.net> (raw)
In-Reply-To: <20050318093158.GE16066@tpkurt.garloff.de>

Kurt Garloff wrote:
> You're very flexible in your setuid root client.
> 
> 1. You may restrict the set of users that is able to call the client,
>    e.g. it might be root:trusted 4750. This would impose the same 
>    restrictions as your group protection mechanism. 

With the group-protected unix domain socket, you don't need any code
to do that.

> 2. The first thing the client does it to acquire the privileged 
>    port and then drop capabilities immediately afterwards. Security
>    flaws in the client will thus at most grant the exploiter a
>    privileged socket. (This has nothing to do with xen, just a
>    general rule for setuid root apps.)

With the group-protected unix domain socket, security flaws in the
client will at most grant a not-used-for-anything-else group membership,
which allows one to connect to the xend socket.

That is, security flaws in the client will never be able to directly
give the attacker root access.

Also, xend can only be attacked by people in the group, where as
xend listening on 127.0.0.1 can be attacked by any local user.

> 3. The client can impose whatever restrictions it likes, e.g.
>    checking SSL certificates, asking for passwords, checking
>    a configuration file, whatever.

That's equally true for unix domain sockets.

> I don't see a big difference in neither flexibility nor security.

So you really _want_ to add yet another unnecessary setuid app, where
one really is not needed?


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click

  reply	other threads:[~2005-03-18 11:59 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-04 17:23 severe security issue on dom0/xend/xm/non-root users Adam Heath
2005-03-04 19:01 ` Anthony Liguori
2005-03-04 19:19   ` Rich Persaud
2005-03-04 19:47     ` Anthony Liguori
2005-03-04 19:39       ` Adam Heath
2005-03-04 19:56       ` Bastian Blank
2005-03-05 21:53         ` Rik van Riel
2005-03-05 22:28           ` Bastian Blank
2005-03-06 15:14           ` Tommi Virtanen
2005-03-06 21:14             ` Rik van Riel
2005-03-13 14:55               ` Kurt Garloff
2005-03-13 16:00                 ` Rik van Riel
2005-03-13 17:09                   ` Kurt Garloff
2005-03-13 21:39                 ` David Hopwood
2005-03-13 21:51                   ` Kurt Garloff
2005-03-14 14:58                     ` Philip R Auld
2005-03-14 15:16                       ` Kurt Garloff
2005-03-14 15:54                         ` Philip R Auld
2005-03-14 16:13                           ` Kurt Garloff
2005-03-14 16:44                             ` Anthony Liguori
2005-03-17  6:46                             ` Tommi Virtanen
2005-03-17 15:02                               ` Kurt Garloff
2005-03-18  9:19                                 ` Tommi Virtanen
2005-03-18  9:31                                   ` Kurt Garloff
2005-03-18 11:59                                     ` Tommi Virtanen [this message]
2005-03-19 11:21                                       ` Nuutti Kotivuori
2005-03-19  2:33                                   ` David Hopwood
2005-03-19  6:29                                     ` Anthony Liguori
2005-03-05  3:14       ` David Hopwood
2005-03-05  7:54         ` Anthony Liguori
2005-03-04 19:35   ` Adam Heath
2005-03-04 19:54     ` Anthony Liguori
2005-03-04 19:47       ` Rich Persaud
2005-03-04 23:19       ` Nicholas Lee
  -- strict thread matches above, loose matches on Subject: below --
2005-03-13 17:17 Ian Pratt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=423AC2BD.10601@tv.debian.net \
    --to=tv@tv.debian.net \
    --cc=david.hopwood@blueyonder.co.uk \
    --cc=garloff@suse.de \
    --cc=pauld@egenera.com \
    --cc=xen-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.