From: Steve French <smfrench@austin.rr.com>
To: Jesper Juhl <juhl-lkml@dif.dk>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH][0/7] cifs: file.c cleanups in incremental bits
Date: Sat, 19 Mar 2005 10:45:09 -0600 [thread overview]
Message-ID: <423C5715.3020307@austin.rr.com> (raw)
In-Reply-To: <Pine.LNX.4.62.0503161402550.3141@dragon.hyggekrogen.localhost>
Jesper Juhl wrote:
>Here 's a version of my fs/cifs/file.c cleanup patch split into seven
>chunks for easier review.
>Please use these incremental patches instead of the big one I send you
>earlier since I've made a few changes compared to that.
>
>For your convenience the patches are also available online at :
>http://www.linuxtux.org/~juhl/kernel_patches/fs_cifs_file-cleanups-3-whitespace-changes.patch
>http://www.linuxtux.org/~juhl/kernel_patches/fs_cifs_file-cleanups-3-kfree-changes.patch
>http://www.linuxtux.org/~juhl/kernel_patches/fs_cifs_file-cleanups-3-cifs_init_private.patch
>http://www.linuxtux.org/~juhl/kernel_patches/fs_cifs_file-cleanups-3-cifs_open_inode_helper.patch
>http://www.linuxtux.org/~juhl/kernel_patches/fs_cifs_file-cleanups-3-cifs_convert_flags.patch
>http://www.linuxtux.org/~juhl/kernel_patches/fs_cifs_file-cleanups-3-cifs_get_disposition.patch
>http://www.linuxtux.org/~juhl/kernel_patches/fs_cifs_file-cleanups-3-condense_if_else.patch
>(listed in the order they apply)
>
I have reviewed and applied the first two, and also reviewed the
get_disposition patch (which is also fine). I will review the others
this weekend. Good work - thanks.
>I still haven't managed to get hold of/setup a cifs server to test these
>against, so they are still only compile tested.
>
>
I did some testing of this against Samba server last night.
prev parent reply other threads:[~2005-03-19 16:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-16 13:14 [PATCH][0/7] cifs: file.c cleanups in incremental bits Jesper Juhl
2005-03-19 16:45 ` Steve French [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=423C5715.3020307@austin.rr.com \
--to=smfrench@austin.rr.com \
--cc=juhl-lkml@dif.dk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.