From: Rene Scharfe <rene.scharfe@lsrfire.ath.cx>
To: Jan Engelhardt <jengelh@linux01.gwdg.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH][1/5] Introduce proc_domode
Date: Sun, 20 Mar 2005 11:40:34 +0100 [thread overview]
Message-ID: <423D5322.5060200@lsrfire.ath.cx> (raw)
In-Reply-To: <Pine.LNX.4.61.0503201131510.4344@yvahk01.tjqt.qr>
Jan Engelhardt wrote:
>> +#define MAXMODE 07777
>
>
> I think this should be 0777. SUID, SGID and sticky bit do not belong
> into /proc.
It's not /proc specific, the function proc_domode can be used for all
kinds of sysctls. It enforces a maximum mode, specified in the ->extra1
member of a sysctl table entry. In patches 2 and 5 you can see this
value is 0444 for all five new sysctls.
Rene
next prev parent reply other threads:[~2005-03-20 10:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-20 0:22 [PATCH][0/6] Change proc file permissions with sysctls Rene Scharfe
2005-03-20 4:22 ` Bodo Eggert
2005-03-20 6:08 ` Albert Cahalan
2005-03-20 9:48 ` Jan Engelhardt
2005-03-20 10:14 ` [PATCH][1/5] Introduce proc_domode Rene Scharfe
2005-03-20 10:32 ` Jan Engelhardt
2005-03-20 10:40 ` Rene Scharfe [this message]
2005-03-20 10:14 ` [PATCH][6/5] Bonus: unrelated minor cleanup of enum pid_directory_inos Rene Scharfe
2005-03-20 10:14 ` [PATCH][2/5] Sysctl for proc Rene Scharfe
2005-03-20 10:14 ` [PATCH][4/5] Add inode_operations for proc sysctl Rene Scharfe
2005-03-20 10:14 ` [PATCH][5/5] Four more sysctls Rene Scharfe
2005-03-20 10:14 ` [PATCH][3/5] New member for proc_inode: ctl_name Rene Scharfe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=423D5322.5060200@lsrfire.ath.cx \
--to=rene.scharfe@lsrfire.ath.cx \
--cc=jengelh@linux01.gwdg.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.