All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Suryansh Singh <technosfan14@gmail.com>
Cc: Hans de Goede <hansg@kernel.org>,
	platform-driver-x86@vger.kernel.org,
	 LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] platform/x86: hp-wmi: Add OMEN board 8BA9 thermal profile support
Date: Fri, 24 Jul 2026 14:17:37 +0300 (EEST)	[thread overview]
Message-ID: <423a8ddd-e93e-8aaf-dcd8-d9d54d9a0600@linux.intel.com> (raw)
In-Reply-To: <20260723174443.26906-1-technosfan14@gmail.com>

On Thu, 23 Jul 2026, Suryansh Singh wrote:

> The HP OMEN 16-wd0xxx (board ID: 8BA9) has the same WMI interface
> as other Victus S boards, but requires quirks for correctly
> switching thermal profile.
> 
> Add the DMI board name to victus_s_thermal_profile_boards[] table
> and map it to omen_v1_thermal_params.
> 
> Without this entry, platform profile switching is unavailable,
> preventing fan RPM reporting and controlling.
> 
> Tested on:
>   HP OMEN 16-wd0012TX
>   DMI Board Name: 8BA9
> 
> It has been confirmed that the platform profile is registered
> successfully, and the fan RPMs are readable and controllable.
> 
> Signed-off-by: Suryansh Singh <technosfan14@gmail.com>
> ---
>  drivers/platform/x86/hp/hp-wmi.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/platform/x86/hp/hp-wmi.c b/drivers/platform/x86/hp/hp-wmi.c
> index 8ba286ed8..052c64aa0 100644
> --- a/drivers/platform/x86/hp/hp-wmi.c
> +++ b/drivers/platform/x86/hp/hp-wmi.c
> @@ -201,6 +201,10 @@ static const struct dmi_system_id victus_s_thermal_profile_boards[] __initconst
>  		.matches = { DMI_MATCH(DMI_BOARD_NAME, "8A4D") },
>  		.driver_data = (void *)&omen_v1_legacy_thermal_params,
>  	},
> +	{
> +		.matches = { DMI_MATCH(DMI_BOARD_NAME, "8BA9") },
> +		.driver_data = (void *)&omen_v1_thermal_params,
> +	},

Hi,

This patch is based on too old code. In plaform drivers tree, hp-wmi's 
driver_data scope has been expanded to cover things beyond thermal params.

-- 
 i.


  reply	other threads:[~2026-07-24 11:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-23 17:44 [PATCH] platform/x86: hp-wmi: Add OMEN board 8BA9 thermal profile support Suryansh Singh
2026-07-24 11:17 ` Ilpo Järvinen [this message]
2026-07-24 12:02   ` [PATCH v2] " Suryansh Singh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=423a8ddd-e93e-8aaf-dcd8-d9d54d9a0600@linux.intel.com \
    --to=ilpo.jarvinen@linux.intel.com \
    --cc=hansg@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=technosfan14@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.