From mboxrd@z Thu Jan  1 00:00:00 1970
From: Anthony Liguori <aliguori@us.ibm.com>
Subject: Re: [PATCH] libxen-3.0 (libxc rewrite)
Date: Tue, 22 Mar 2005 10:21:19 -0600
Message-ID: <424045FF.5000908@us.ibm.com>
References: <423F3BB5.3020600@us.ibm.com> <3d8eece2050322030245ed31b@mail.gmail.com> <4240340F.8080600@us.ibm.com> <20050322160146.GQ31328@cl.cam.ac.uk> <42404294.6000101@us.ibm.com> <20050322161350.GR31328@cl.cam.ac.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
In-Reply-To: <20050322161350.GR31328@cl.cam.ac.uk>
Sender: xen-devel-admin@lists.sourceforge.net
Errors-To: xen-devel-admin@lists.sourceforge.net
List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.sourceforge.net?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.sourceforge.net>
List-Help: <mailto:xen-devel-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.sourceforge.net?subject=subscribe>
List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum=xen-devel>
To: Christian Limpach <Christian.Limpach@cl.cam.ac.uk>
Cc: xen-devel@lists.sourceforge.net
List-Id: xen-devel@lists.xenproject.org

Christian Limpach wrote:

>>You're right.  Some of the interfaces are a little awkward (especially 
>>the memory mapping ones).  It seemed like a reasonable trade-off to make 
>>though.
>>    
>>
>
>What about perror, warn, err and the likes, I really like to use those.
>It seems very illogical having to stick the returned value into errno to be
>able to use those...
>  
>
You're not going to like this answer but I don't think I would use any 
of those functions in a real management application.  Management tools 
should be using standard logging suites (like syslog).

strerror() still works with these return codes btw.  My test code 
usually likes like this:

domid_t domid;
int ret = dom_create_domain(3000, 0, &domid);

if (ret < 0) error("dom_create_domain: failed %s", strerror(-ret));

This would be even easier if the library returned errno instead of 
-errno ;-)

Regards,
Anthony Liguori


-------------------------------------------------------
This SF.net email is sponsored by: 2005 Windows Mobile Application Contest
Submit applications for Windows Mobile(tm)-based Pocket PCs or Smartphones
for the chance to win $25,000 and application distribution. Enter today at
http://ads.osdn.com/?ad_id=6882&alloc_id=15148&op=click