From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [PATCH] tool xfrd x86-64 compilation fix. Date: Tue, 22 Mar 2005 13:05:36 -0600 Message-ID: <42406C80.3060202@us.ibm.com> References: <1111517674.2106.8.camel@thinkpad> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit In-Reply-To: <1111517674.2106.8.camel@thinkpad> Sender: xen-devel-admin@lists.sourceforge.net Errors-To: xen-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: To: Jerone Young Cc: xen-devel List-Id: xen-devel@lists.xenproject.org size_t seems like the right type here. Probably should be: fwrite(data, buf_n, 1, stdout); printf("\n"); Regards, Anthony Liguori Jerone Young wrote: >Fix curldebug function in xendomain.c of xfrd. Function takes argument >"size_t buf_num" and uses it as the field width to print, that has to be >an int. While size_t on 32 bit systems is 4bytes (or size of an int) it >is 8bytes on 64bit systems (not size of an int). So this function should >just use "int buf_num". This function is not used in the code anywhere. >This will fix compilation on x86-64. > >Signed-off-by: Jerone Young > >--- tools/xfrd/xen_domain.c.orig 2005-03-22 12:52:04.156581136 -0600 >+++ tools/xfrd/xen_domain.c 2005-03-22 12:52:23.369660304 -0600 >@@ -176,7 +176,7 @@ static CURL *curlinit(void){ > > /** Curl debug function. > */ >-int curldebug(CURL *curl, curl_infotype ty, char *buf, size_t buf_n, >void *data){ >+int curldebug(CURL *curl, curl_infotype ty, char *buf, int buf_n, void >*data){ > printf("%*s\n", buf_n, buf); > return 0; > } > > > > ------------------------------------------------------- This SF.net email is sponsored by: 2005 Windows Mobile Application Contest Submit applications for Windows Mobile(tm)-based Pocket PCs or Smartphones for the chance to win $25,000 and application distribution. Enter today at http://ads.osdn.com/?ad_id=6882&alloc_id=15148&op=click