From: Jeff Garzik <jgarzik@pobox.com>
To: Michael Chan <mchan@broadcom.com>
Cc: "David S. Miller" <davem@davemloft.net>, netdev@oss.sgi.com
Subject: Re: [PATCH 2.6.11 3/8] tg3: Add msi support for 5750 C0
Date: Tue, 22 Mar 2005 15:56:25 -0500 [thread overview]
Message-ID: <42408679.7020407@pobox.com> (raw)
In-Reply-To: <B1508D50A0692F42B217C22C02D84972020F3E23@NT-IRVA-0741.brcm.ad.broadcom.com>
Michael Chan wrote:
> Add MSI support for 5750 C0 and newer chips. MSI is handled by a new
> interrupt service routine that is very similar to the existing
> tg3_interrupt() for INTx mode. The MSI version is optimized by not checking
> for shared interrupt and not flushing the status block.
>
> The code is also changed to reference the irq from tp->pdev->irq instead of
> dev->irq.
>
> Signed-off-by: Michael Chan <mchan@broadcom.com
I would prefer that a new 'static inline' function was created,
containing the core interrupt handler code.
This avoids the code duplication you have in this patch, in new function
tg3_msi().
Jeff
next prev parent reply other threads:[~2005-03-22 20:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-21 7:34 [PATCH 2.6.11 3/8] tg3: Add msi support for 5750 C0 Michael Chan
2005-03-22 20:56 ` Jeff Garzik [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-03-23 0:24 Michael Chan
2005-03-23 0:28 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42408679.7020407@pobox.com \
--to=jgarzik@pobox.com \
--cc=davem@davemloft.net \
--cc=mchan@broadcom.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.