Re: Fw: [Bugme-new] [Bug 4381] New: When i try to start a pppoe conn., crash at net/core/skbuff.c:91

[Patrick McHardy <kaber@trash.net>]

[-- Attachment #1: Type: text/plain, Size: 719 bytes --]

Andrew Morton wrote:
> Repeatable pppoe crash :(
> 
> 
> Begin forwarded message:
> 
> http://bugme.osdl.org/show_bug.cgi?id=4381
> 
>            Summary: When i try to start a pppoe conn., crash at
>                     net/core/skbuff.c:91
>     Kernel Version: 2.6.11 (gentoo-dev-sources)
>             Status: NEW
>           Severity: blocking
>              Owner: shemminger@osdl.org
>          Submitter: o.cornu@gmail.com
> 
> Mar 21 21:28:05 Pai-mei <6>skput:over: f89b2335:16 put:16
> dev:<NULL>

Looks like hdrlen is uninitialized in ppp_async. This patch
initializes it to 2 like in ppp_synctty, but I'm not sure
whether this value is correct here. Paul?

Signed-off-by: Patrick McHardy <kaber@trash.net>


[-- Attachment #2: x --]
[-- Type: text/plain, Size: 366 bytes --]

===== drivers/net/ppp_async.c 1.26 vs edited =====
--- 1.26/drivers/net/ppp_async.c	2005-01-21 06:02:12 +01:00
+++ edited/drivers/net/ppp_async.c	2005-03-23 03:15:31 +01:00
@@ -183,6 +183,7 @@
 	ap->chan.private = ap;
 	ap->chan.ops = &async_ops;
 	ap->chan.mtu = PPP_MRU;
+	ap->chan.hdrlen = 2;
 	err = ppp_register_channel(&ap->chan);
 	if (err)
 		goto out_free;