From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com ([134.134.136.20]) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1TGnzG-0000vX-Sa for bitbake-devel@lists.openembedded.org; Wed, 26 Sep 2012 11:32:59 +0200 Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP; 26 Sep 2012 02:20:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.80,489,1344236400"; d="scan'208";a="197886785" Received: from unknown (HELO helios.localnet) ([10.252.122.36]) by orsmga001.jf.intel.com with ESMTP; 26 Sep 2012 02:20:04 -0700 From: Paul Eggleton To: Ioana Grigoropol Date: Wed, 26 Sep 2012 10:20:02 +0100 Message-ID: <4243638.dprUypd7aI@helios> Organization: Intel Corporation User-Agent: KMail/4.9.1 (Linux/3.2.0-31-generic-pae; KDE/4.9.1; i686; ; ) In-Reply-To: <1348564865-23697-1-git-send-email-ioanax.grigoropol@intel.com> References: <1348564865-23697-1-git-send-email-ioanax.grigoropol@intel.com> MIME-Version: 1.0 Cc: bitbake-devel@lists.openembedded.org Subject: Re: [PATCH] hob: Buttons width and height are taken for host X-BeenThere: bitbake-devel@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Sep 2012 09:32:59 -0000 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Hi Ioana, On Tuesday 25 September 2012 12:21:05 Ioana Grigoropol wrote: > - removed all set_size_request calls for buttons in order to: > - force autosizing of buttons with regard to the text length > - use host theme default height for buttons > - modified buttons on image details page to have the same height (default > host one) and the width of the button with the largest text - modified Stop > button on build details page to have the default height by directly > attaching it to the containing table instead of hbox > > Signed-off-by: Ioana Grigoropol > --- > bitbake/lib/bb/ui/crumbs/builddetailspage.py | 12 +-- > bitbake/lib/bb/ui/crumbs/hig.py | 2 +- > bitbake/lib/bb/ui/crumbs/imageconfigurationpage.py | 15 +-- > bitbake/lib/bb/ui/crumbs/imagedetailspage.py | 101 > ++++++++++++++++---- bitbake/lib/bb/ui/crumbs/packageselectionpage.py | > 2 +- > bitbake/lib/bb/ui/crumbs/recipeselectionpage.py | 2 +- > 6 files changed, 102 insertions(+), 32 deletions(-) > > diff --git a/bitbake/lib/bb/ui/crumbs/builddetailspage.py > b/bitbake/lib/bb/ui/crumbs/builddetailspage.py index a927c21..5add31d > 100755 > --- a/bitbake/lib/bb/ui/crumbs/builddetailspage.py > +++ b/bitbake/lib/bb/ui/crumbs/builddetailspage.py > @@ -165,7 +165,7 @@ class BuildDetailsPage (HobPage): > self.builder.handler.build.model.connect_after("row-changed", > self.scroll_to_present_row, self.scrolled_view_build.get_vadjustment(), > self.build_tv) > > self.button_box = gtk.HBox(False, 6) > - self.back_button = HobAltButton('<< Back') > + self.back_button = HobAltButton('<< Back') I did make this change to avoid a runtime warning due to invalid markup - did you change it back on purpose? If so I don't see it mentioned in the commit message. Cheers, Paul -- Paul Eggleton Intel Open Source Technology Centre