From: Andrew Wozniak <awozniak@mc.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] OCOTEA get_timer() bug
Date: Mon, 28 Mar 2005 14:25:38 -0500 [thread overview]
Message-ID: <42485A32.6090501@mc.com> (raw)
I found this bug a while ago and have finally gotten around to looking
at it because I needed its service.
In previous posts to this email list, Wolfgang had mentioned that the
"time unit" returned by get_timer() is 1 msec. Close examination of
interrupt_init_cpu() at cpu/ppc4xx/interrupts.c suggests a timer
interval setup of 10 msec!
A quick experiment via u-boot application, shows this to be true:
printf("...tic\n");
tic = get_timer(0);
udelay(2000000); /* 2sec delay so that I can "see" it */
toc = get_timer(0);
printf("...toc\n %d %d\n", tic, toc);
run it:
...tic
...toc
1278 1478
therefore:
200 = delta
2sec/200 = 10msec time unit from get_timer()
I've tested the following and propose it as a fix, replace this:
val = gd->bd->bi_intfreq/100; /* 10 msec */
with:
val = gd->bd->bi_intfreq/1000; /* 1 msec */
I've also tested some of the network related functions to insure that no
timeout conditions have appeared.
I want to post this patch but would prefer a code review from those that
are more familiar with get_timer() use within the OCOTEA codebase.
Sorry for the long post, Andrew
next reply other threads:[~2005-03-28 19:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-28 19:25 Andrew Wozniak [this message]
2005-03-28 19:58 ` [U-Boot-Users] OCOTEA get_timer() bug Wolfgang Denk
2005-03-29 6:26 ` Stefan Roese
2005-03-29 23:17 ` Andrew Wozniak
2005-03-30 7:13 ` Stefan Roese
2005-03-31 18:26 ` Andrew Wozniak
2005-04-04 17:35 ` Travis B. Sawyer
2005-04-05 13:26 ` Travis B. Sawyer
2005-04-05 14:08 ` Travis B. Sawyer
2005-04-05 22:52 ` Andrew Wozniak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42485A32.6090501@mc.com \
--to=awozniak@mc.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.