From: Patrick McHardy <kaber@trash.net>
To: hadi@cyberus.ca
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
Masahide NAKAMURA <nakam@linux-ipv6.org>,
"David S. Miller" <davem@davemloft.net>,
netdev <netdev@oss.sgi.com>
Subject: Re: RFC: IPSEC patch 0 for netlink events
Date: Mon, 28 Mar 2005 23:23:19 +0200 [thread overview]
Message-ID: <424875C7.3080306@trash.net> (raw)
In-Reply-To: <1111950449.1089.938.camel@jzny.localdomain>
jamal wrote:
> @@ -478,6 +491,9 @@
>
> if (x1->km.state == XFRM_STATE_ACQ) {
> __xfrm_state_insert(x);
> + /* XXXX: We already have xfrm_state_lock
> + * do we need to grab x->lock as well? */
> + xfrm_sa_notify(x, c, XFRM_SA_ADDED);
To answer this question: no. xfrm_state_lock can be nested in
x->lock, but not the other way around. If you want to avoid that
the state changes below you, you could notify before insertion.
Regards
Patrick
next prev parent reply other threads:[~2005-03-28 21:23 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-26 19:22 RFC: IPSEC patch 0 for netlink events jamal
2005-03-26 19:40 ` Herbert Xu
2005-03-26 20:05 ` jamal
2005-03-27 8:24 ` Herbert Xu
2005-03-26 19:47 ` Herbert Xu
2005-03-26 20:11 ` jamal
2005-03-27 8:18 ` Herbert Xu
2005-03-27 19:07 ` jamal
2005-03-28 21:23 ` Patrick McHardy [this message]
2005-03-28 23:43 ` Herbert Xu
2005-03-30 0:49 ` Herbert Xu
2005-03-30 12:09 ` jamal
2005-03-30 12:23 ` Herbert Xu
2005-03-30 12:32 ` Herbert Xu
2005-03-30 12:53 ` jamal
2005-03-30 13:14 ` Herbert Xu
2005-03-30 13:24 ` jamal
2005-03-31 2:55 ` jamal
2005-03-31 3:00 ` Herbert Xu
2005-03-31 3:01 ` Herbert Xu
2005-03-31 3:18 ` jamal
2005-03-30 12:55 ` Herbert Xu
2005-03-30 13:18 ` jamal
2005-03-30 13:27 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=424875C7.3080306@trash.net \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=hadi@cyberus.ca \
--cc=herbert@gondor.apana.org.au \
--cc=nakam@linux-ipv6.org \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.