All of lore.kernel.org
 help / color / mirror / Atom feed
From: Darrel Goeddel <dgoeddel@TrustedCS.com>
To: James Morris <jmorris@redhat.com>
Cc: Steve G <linux_4ever@yahoo.com>, selinux@tycho.nsa.gov
Subject: Re: Getting the real task name in avc messages
Date: Wed, 30 Mar 2005 16:27:06 -0600	[thread overview]
Message-ID: <424B27BA.8060706@trustedcs.com> (raw)
In-Reply-To: <Xine.LNX.4.44.0503301704130.15296-100000@thoron.boston.redhat.com>

James Morris wrote:
> On Wed, 30 Mar 2005, James Morris wrote:
> 
> 
>>This will be looked upon dimly upstream:
>>
>>+        char name[sizeof(current->comm)];
>>
>>the kernel stack space is very limited.
> 
> 
> Actually, current->comm is only defined by default to be 16 bytes, so it's 
> ok.
> 
> 
> - James

You could also just do:

	task_lock(current);
	audit_log_format(ab, " comm=%s", current->comm);
	task_unlock(current);

This avoids an unnecessary copy since we have no use the data after the
audit_log_format call.

I really like the idea of moving this functionality to the standard
syscall audit record.  I'm sure that this would be nice info to have
for folks who do not run SELinux.

-- 

Darrel

--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.

  reply	other threads:[~2005-03-30 22:26 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-30 19:53 Getting the real task name in avc messages Steve G
2005-03-30 20:41 ` Stephen Smalley
2005-03-30 21:09   ` Stephen Smalley
2005-03-30 20:50 ` James Morris
2005-03-30 22:04   ` James Morris
2005-03-30 22:27     ` Darrel Goeddel [this message]
2005-03-31 12:30       ` Stephen Smalley
2005-03-31 13:36         ` Stephen Smalley
2005-03-31 15:21         ` Darrel Goeddel
2005-03-31 15:20           ` Stephen Smalley
  -- strict thread matches above, loose matches on Subject: below --
2005-03-30 21:02 Steve G
2005-03-30 21:14 ` Stephen Smalley
2005-03-31 14:53 Steve G
2005-03-31 15:00 ` Stephen Smalley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=424B27BA.8060706@trustedcs.com \
    --to=dgoeddel@trustedcs.com \
    --cc=jmorris@redhat.com \
    --cc=linux_4ever@yahoo.com \
    --cc=selinux@tycho.nsa.gov \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.