From: Jeff Garzik <jgarzik@pobox.com>
To: Yum Rayan <yum.rayan@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Reduce stack usage in sys.c
Date: Thu, 31 Mar 2005 03:29:30 -0500 [thread overview]
Message-ID: <424BB4EA.6080506@pobox.com> (raw)
In-Reply-To: <df35dfeb05033023445c386d2d@mail.gmail.com>
Yum Rayan wrote:
> Attempt to reduce stack usage in sys.c (linux-2.6.12-rc1-mm3). Stack
> usage was noted using checkstack.pl. Specifically
>
> Before patch
> ------------
> sys_reboot - 256
>
> After patch
> -----------
> sys_reboot - none (register usage only)
>
> Along the way, wrap code to 80 column width and cleanup lock usage.
Your "cleanup lock usage" increases the number of lock_kernel() calls
quite a bit, which is not really a cleanup but simply bloat.
Seperate out your patches; don't sneak these supposed-cleanups into
stack uage patches.
Jeff
next prev parent reply other threads:[~2005-03-31 8:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-31 7:44 [PATCH] Reduce stack usage in sys.c Yum Rayan
2005-03-31 8:29 ` Jeff Garzik [this message]
2005-04-02 7:05 ` [PATCH] Cleanup locking in sys_reboot() (was Re: [PATCH] Reduce stack usage in sys.c) Yum Rayan
2005-03-31 13:01 ` [PATCH] Reduce stack usage in sys.c Jörn Engel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=424BB4EA.6080506@pobox.com \
--to=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=yum.rayan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.