All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: lartc@vger.kernel.org
Subject: Re: [LARTC] new perflow rate control queue
Date: Mon, 04 Apr 2005 08:51:15 +0000	[thread overview]
Message-ID: <42510003.1060609@trash.net> (raw)
In-Reply-To: <20050404152117.6d90635d.lark@linux.net.cn>

Wang Jian wrote:
> Hi,
> 
> One of my customer needs per flow rate control, so I write one.
> 
> The code I post here is not finished, but it seems to work as expected.
> 
> The kernel patch is agains kernel 2.6.11, the iproute2 patch is against
> iproute2-2.6.11-050314. 
> 
> I write the code in a hurry to meet deadline. There are many other things
> to do ahead for me. The code is written in 2 days (including read other
> queue's code) and tested for a while to find obvious mistake. Don't be
> suprised when you find many many bugs.

It looks quite clean, but couldn't the same be achieved with just
providing per-flow fairness and leaving the rate-limiting to an
upper qdisc like HTB or HFSC?

Regards
Patrick
_______________________________________________
LARTC mailing list
LARTC@mailman.ds9a.nl
http://mailman.ds9a.nl/cgi-bin/mailman/listinfo/lartc

  reply	other threads:[~2005-04-04  8:51 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-04  7:21 [LARTC] new perflow rate control queue Wang Jian
2005-04-04  8:51 ` Patrick McHardy [this message]
2005-04-04  9:10 ` Wang Jian
2005-04-04 11:42 ` Andy Furniss
2005-04-04 13:53 ` Wang Jian
2005-04-04 14:39 ` Wang Jian
2005-04-04 15:10 ` Andy Furniss
2005-04-04 15:23 ` Andy Furniss
2005-04-04 15:57 ` Wang Jian
2005-04-05 22:40 ` Andy Furniss
2005-04-06  4:17 ` Wang Jian
2005-04-06 12:29 ` Andy Furniss
2005-04-06 12:48 ` Wang Jian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42510003.1060609@trash.net \
    --to=kaber@trash.net \
    --cc=lartc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.