All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Randy.Dunlap" <rddunlap@osdl.org>
To: maximilian attems <janitor@sternwelten.at>
Cc: lkml <linux-kernel@vger.kernel.org>, akpm <akpm@osdl.org>,
	ambx1@neo.rr.com
Subject: Re: [patch 1/3] pnpbios eliminate bad section references
Date: Mon, 04 Apr 2005 12:56:32 -0700	[thread overview]
Message-ID: <42519BF0.8090404@osdl.org> (raw)
In-Reply-To: <20050404181048.GA12394@sputnik.stro.at>

maximilian attems wrote:
> one of the last buildcheck errors on i386,
> thanks Randy again for double checking.
> 
> Fix pnpbios section references:
> make dmi_system_id pnpbios_dmi_table __initdata
> 
> Error: ./drivers/pnp/pnpbios/core.o .data refers to 00000100 R_386_32
> .init.text
> Error: ./drivers/pnp/pnpbios/core.o .data refers to 0000012c R_386_32
> .init.text
> 
> Signed-off-by: maximilian attems <janitor@sternwelten.at>
> 
> 
> --- linux-2.6.12-rc1-bk5/drivers/pnp/pnpbios/core.c.orig	2005-04-04 19:11:37.814477672 +0200
> +++ linux-2.6.12-rc1-bk5/drivers/pnp/pnpbios/core.c	2005-04-04 19:25:50.074402365 +0200
> @@ -512,7 +512,7 @@
>  	return 0;
>  }
>  
> -static struct dmi_system_id pnpbios_dmi_table[] = {
> +static struct dmi_system_id pnpbios_dmi_table[] __initdata = {
>  	{	/* PnPBIOS GPF on boot */
>  		.callback = exploding_pnp_bios,
>  		.ident = "Higraded P14H",

Looks OK to me, but I'd prefer to leave it up to Adam.....

-- 
~Randy



  reply	other threads:[~2005-04-04 19:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-04 18:10 [patch 1/3] pnpbios eliminate bad section references maximilian attems
2005-04-04 19:56 ` Randy.Dunlap [this message]
2005-04-04 23:04   ` Adam Belay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42519BF0.8090404@osdl.org \
    --to=rddunlap@osdl.org \
    --cc=akpm@osdl.org \
    --cc=ambx1@neo.rr.com \
    --cc=janitor@sternwelten.at \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.