From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Hopwood Subject: Re: [PATCH] stream fixes for migration Date: Tue, 05 Apr 2005 02:57:49 +0100 Message-ID: <4251F09D.20907@blueyonder.co.uk> References: <4251E752.3070500@blueyonder.co.uk> <200504040241.05209.mark.williamson@cl.cam.ac.uk> Reply-To: david.nospam.hopwood@blueyonder.co.uk Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <200504040241.05209.mark.williamson@cl.cam.ac.uk> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org Mark Williamson wrote: >>doing anything to a c stream will work in a multithreaded environment; ie, >>the internal buffers/vars will not be stompped on. >> >>It's in the spec(don't ask me where, I read it in the info docs). > > I think the issue is with Xfrd's IOStream type (libxutil/iostream.h), rather > than with standard C streams. > > (and I don't know if they're safe for multiple users, although I would expect > that they're single thread-oriented) Well, the patch seemed to be assuming that they don't need to be safe for multiple threads. For example, the patch tries to make multiple closes safe, but this won't work if the closes are concurrent. I was just checking that no-one was expecting this to work. -- David Hopwood